Merge pull request #409 from epriestley/master

Add "rule" attribute to "lintxml" output format

Author: XhmikosR

src/formatters/lint-xml.js

@@ -59,7 +59,11 @@ CSSLint.addFormatter({
                 if (message.rollup) {
                     output.push("<issue severity=\"" + message.type + "\" reason=\"" + escapeSpecialCharacters(message.message) + "\" evidence=\"" + escapeSpecialCharacters(message.evidence) + "\"/>");
                 } else {
-                    output.push("<issue line=\"" + message.line + "\" char=\"" + message.col + "\" severity=\"" + message.type + "\"" +
+                    var rule = '';
+                    if (message.rule && message.rule.id) {
+                      rule = 'rule=\"' + escapeSpecialCharacters(message.rule.id) + '\" ';
+                    }
+                    output.push("<issue " + rule + "line=\"" + message.line + "\" char=\"" + message.col + "\" severity=\"" + message.type + "\"" +
                         " reason=\"" + escapeSpecialCharacters(message.message) + "\" evidence=\"" + escapeSpecialCharacters(message.evidence) + "\"/>");
                 }
             });

tests/formatters/lint-xml.js

@@ -37,6 +37,25 @@
                 expected = "<?xml version=\"1.0\" encoding=\"utf-8\"?><lint>" + file + error1 + error2 + "</file></lint>",
                 actual = CSSLint.format(result, "FILE", "lint-xml");
             Assert.areEqual(expected, actual);
+        },
+
+        "Messages should include rule IDs": function() {
+          var result = { messages: [
+            { type: "error", line: 1, col: 1, message: "X", evidence: "Y", rule: { id: "Z" } }
+          ], stats: [] };
+
+          var expected =
+            '<?xml version="1.0" encoding="utf-8"?>' +
+            '<lint>' +
+              '<file name="FILE">' +
+                '<issue rule="Z" line="1" char="1" severity="error" reason="X" evidence="Y"/>' +
+              '</file>' +
+            '</lint>';
+
+          var actual = CSSLint.format(result, "FILE", "lint-xml");
+
+          Assert.areEqual(expected, actual);
         }
+
     }));
 })();