CSSLint.verify() undocumentedly modifies ruleset argument in-place

[cvrebert]

CSSLint.verify() calls applyEmbeddedRuleset(), which modifies the ruleset object _in-place_. This potential modification of the ruleset argument passed to verify() is not mentioned in verify()'s docs, which leads to bugs like gruntjs/grunt-contrib-csslint#26 when the caller attempts to verify multiple files against the same ruleset.

I propose that either the ruleset object should be defensively copied before modification, or a mention of this side-effect should be added to verify()'s docs.

[stubbornella]

Which do you think is the right better option?

On Thu, Feb 27, 2014 at 9:57 PM, Chris Rebert notifications@github.comwrote:

CSSLint.verify() calls applyEmbeddedRuleset(), which modifies the rulesetobject
in-place. This potential modification of the ruleset argument passed to
verify() is not mentioned in verify()'s docs, which leads to bugs like
gruntjs/grunt-contrib-csslint#26https://github.com/gruntjs/grunt-contrib-csslint/issues/26when the caller attempts to verify multiple files against the same ruleset.

I propose that either the ruleset object should be defensively copied
before modification, or a mention of this side-effect should be added to
verify()'s docs.

Reply to this email directly or view it on GitHubhttps://github.com//issues/458
.

[cvrebert]

The copying, since it requires less effort from the user.

[cvrebert]

Proposed a fix: #465.