Try to fix selector-newline rule. #495
Merged
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bump |
Member
There was a problem hiding this comment.
The third example here should fail due to the linebreak after the >
Member
Author
There was a problem hiding this comment.
No it shouldn't. Check out the branch locally to review and test...
Member
|
Other piece I wanted to test is selector depth beyond 2 |
Member
Author
|
bump From my tests this seems to work fine, can we get this in? Unless someone noticed something wrong ofc. |
nschonni
added a commit
that referenced
this pull request
May 2, 2014
Try to fix selector-newline rule.
Member
|
Sorry, in the middle of trying to move cities so I got a little distracted 😉 |
Member
Author
|
No worries, @nschonni, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490.
This could probably be simplified, but I just wanted to get a working solution. If anyone wants to improve this, please, go ahead. But it seems to work properly.