Skip to content

Commit 172a2b2

Browse files
committed
Merge pull request #30 from mirceapiturca/master
MediaQuery.text minor bug
2 parents 4c2d521 + a66dfbd commit 172a2b2

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

build/node-parserlib.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1169,7 +1169,7 @@ MediaFeature.prototype.constructor = MediaFeature;
11691169
*/
11701170
function MediaQuery(modifier, mediaType, features, line, col){
11711171

1172-
SyntaxUnit.call(this, (modifier ? modifier + " ": "") + (mediaType ? mediaType + " " : "") + features.join(" and "), line, col, Parser.MEDIA_QUERY_TYPE);
1172+
SyntaxUnit.call(this, (modifier ? modifier + " ": "") + (mediaType ? mediaType : "") + (mediaType && features.length > 0 ? " and " : "") + features.join(" and "), line, col, Parser.MEDIA_QUERY_TYPE);
11731173

11741174
/**
11751175
* The media modifier ("not" or "only")

src/css/MediaQuery.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414
function MediaQuery(modifier, mediaType, features, line, col){
1515

16-
SyntaxUnit.call(this, (modifier ? modifier + " ": "") + (mediaType ? mediaType + " " : "") + features.join(" and "), line, col, Parser.MEDIA_QUERY_TYPE);
16+
SyntaxUnit.call(this, (modifier ? modifier + " ": "") + (mediaType ? mediaType : "") + (mediaType && features.length > 0 ? " and " : "") + features.join(" and "), line, col, Parser.MEDIA_QUERY_TYPE);
1717

1818
/**
1919
* The media modifier ("not" or "only")

tests/css/Parser.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -891,6 +891,7 @@
891891
Assert.isNull(result.modifier);
892892
Assert.areEqual("print", result.mediaType);
893893
Assert.areEqual(0, result.features.length, "Should be zero parts.");
894+
Assert.areEqual("print", result.text);
894895
},
895896

896897
testSimpleMediaQueryNot: function(){
@@ -903,6 +904,7 @@
903904
Assert.areEqual("not", result.modifier);
904905
Assert.areEqual("print", result.mediaType);
905906
Assert.areEqual(0, result.features.length, "Should be zero parts.");
907+
Assert.areEqual("not print", result.text);
906908
},
907909

908910
testSimpleMediaQueryOnly: function(){
@@ -915,6 +917,7 @@
915917
Assert.areEqual("only", result.modifier);
916918
Assert.areEqual("print", result.mediaType);
917919
Assert.areEqual(0, result.features.length, "Should be zero parts.");
920+
Assert.areEqual("only print", result.text);
918921
},
919922

920923
testComplexMediaQuery: function(){
@@ -933,6 +936,7 @@
933936
Assert.areEqual("color", result.features[1].name);
934937
Assert.isNull(result.features[1].value);
935938
Assert.areEqual(35, result.features[1].name.col);
939+
Assert.areEqual("screen and (max-weight: 3kg) and (color)", result.text);
936940

937941
},
938942

@@ -950,6 +954,7 @@
950954
Assert.areEqual("768px", result.features[0].value);
951955
Assert.areEqual("orientation", result.features[1].name);
952956
Assert.areEqual("portrait", result.features[1].value);
957+
Assert.areEqual("only screen and (max-device-width: 768px) and (orientation:portrait)", result.text);
953958
}
954959

955960

0 commit comments

Comments
 (0)