clean up some todos

Author: EarthenSky

src/officers/constants.py

@@ -121,8 +121,6 @@ def expected_positions() -> list[str]:
     OfficerPosition.SOCIAL_MEDIA_MANAGER: "N/A",
 }
 
-# TODO: when an officer's start date is modified, update the end date as well if it's defined in this list
-# a number of semesters (a semester begins on the 1st of each four month period, starting january)
 # None, means that the length of the position does not have a set length in semesters
 _LENGTH_MAP = {
     OfficerPosition.PRESIDENT: 3,

src/officers/crud.py

@@ -42,7 +42,7 @@ async def current_officers(
         )
         officer_info = (await db_session.scalars(officer_info_query)).first()
         if officer_info is None:
-            # TODO: make sure there are daily checks that this data actually exists
+            # TODO (#93): make sure there are daily checks that this data actually exists
             continue
         elif term.position not in officer_data:
             officer_data[term.position] = []

src/officers/tables.py

@@ -5,10 +5,8 @@
     Date,
     ForeignKey,
     Integer,
-    Select,
     String,
     Text,
-    and_,
 )
 
 # from sqlalchemy.orm import relationship
@@ -112,7 +110,7 @@ class OfficerInfo(Base):
         primary_key=True,
     )
 
-    # TODO: we'll need to use SFU's API to get the legal name for users
+    # TODO (#71): we'll need to use SFU's API to get the legal name for users
     legal_name = Column(String(128), nullable=False) # some people have long names, you never know
     phone_number = Column(String(24), nullable=True)
 
@@ -166,7 +164,7 @@ def is_filled_in(self):
 
     def to_update_dict(self) -> dict:
         return {
-            # TODO: if the API call to SFU's api to get legal name fails, we want to fail & not insert the entry.
+            # TODO (#71): if the API call to SFU's api to get legal name fails, we want to fail & not insert the entry.
             # for now, we should insert a default value
             "legal_name": "default name" if self.legal_name is None else self.legal_name,
 

src/officers/types.py

@@ -114,7 +114,7 @@ class OfficerTermUpload:
     start_date: date
     end_date: None | date = None
 
-    # officer should change
+    # officer should change:
     nickname: None | str = None
     favourite_course_0: None | str = None
     favourite_course_1: None | str = None