fix: all elections unit tests pass

Author: jbriones1

src/elections/urls.py

@@ -533,7 +533,6 @@ async def update_registration(
         )
 
     registration = await elections.crud.get_one_registration_in_election(db_session, computing_id, slugified_name, position)
-
     if not registration:
         raise HTTPException(
             status_code=status.HTTP_404_NOT_FOUND,
@@ -632,7 +631,7 @@ async def get_nominee_info(
             detail="nominee doesn't exist"
         )
 
-    return JSONResponse(nominee_info)
+    return JSONResponse(nominee_info.serialize())
 
 @router.patch(
     "/nominee/{computing_id:str}",
@@ -695,4 +694,4 @@ async def provide_nominee_info(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="failed to get updated nominee"
         )
-    return JSONResponse(nominee_info)
+    return JSONResponse(nominee_info.serialize())

tests/integration/test_elections.py

@@ -267,7 +267,6 @@ async def test_endpoints_admin(client, database_setup):
 
     # update the registration
     await client.patch(f"/elections/registration/{election_name}/vice-president/pkn4", json={
-        "position": "president",
         "speech": "Vote for me as treasurer"
     })
     assert response.status_code == 200
@@ -284,19 +283,19 @@ async def test_endpoints_admin(client, database_setup):
     assert response.status_code == 200
 
     # delete a registration
-    response = await client.delete(f"/elections/registration/{election_name}/president")
+    response = await client.delete(f"/elections/registration/{election_name}/president/jdo12")
     assert response.status_code == 200
 
     # get nominee info
-    response = await client.get("/elections/nominee/info")
+    response = await client.get(f"/elections/nominee/{load_test_db.SYSADMIN_COMPUTING_ID}")
     assert response.status_code == 200
 
     # update nominee info
-    response = await client.put("/elections/nominee/info", json={
+    response = await client.patch(f"/elections/nominee/{load_test_db.SYSADMIN_COMPUTING_ID}", json={
         "full_name": "Puneet N",
         "linked_in": "linkedin.com/not-my-linkedin",
     })
     assert response.status_code == 200
 
-    response = await client.get("/elections/nominee/info")
+    response = await client.get(f"/elections/nominee/{load_test_db.SYSADMIN_COMPUTING_ID}")
     assert response.status_code == 200