remove comment

Author: EarthenSky

src/officers/crud.py

@@ -189,7 +189,10 @@ async def all_officer_data(
 
     return officer_data_list
 
-async def create_new_officer_info(db_session: database.DBSession, new_officer_info: OfficerInfo) -> bool:
+async def create_new_officer_info(
+    db_session: database.DBSession,
+    new_officer_info: OfficerInfo
+) -> bool:
     """
     Return False if the officer already exists
     """
@@ -205,13 +208,13 @@ async def create_new_officer_info(db_session: database.DBSession, new_officer_in
     db_session.add(new_officer_info)
     return True
 
-# TODO: implement this for patch term as well
 async def create_new_officer_term(
     db_session: database.DBSession,
     new_officer_term: OfficerTerm
 ):
-    if new_officer_term.position not in OfficerPosition.position_list():
-        raise HTTPException(status_code=500)
+    # TODO: does this check need to be here?
+    # if new_officer_term.position not in OfficerPosition.position_list():
+    #     raise HTTPException(status_code=500)
 
     position_length = OfficerPosition.length_in_semesters(new_officer_term.position)
     if position_length is not None:

src/officers/tables.py

@@ -98,7 +98,6 @@ def sql_is_filled_in(query: Select) -> Select:
             )
         )
 
-
     def to_update_dict(self) -> dict:
         return {
             # TODO: do we want computing_id to be changeable?

src/officers/types.py

@@ -67,7 +67,6 @@ def validate(self):
         elif self.end_date is not None and self.start_date > self.end_date:
             raise HTTPException(status_code=400, detail="end_date must be after start_date")
 
-
     def to_officer_term(self, term_id: str, computing_id:str) -> OfficerTerm:
         # TODO: many positions have a length; if the length is defined, fill it in right here
         # (end date is 1st of month, 12 months after start date's month).