feat: Migration for Elections and Officers

- closes #71: Added unique constraint Officer Term
- Changed TIMESTAMP to DATETIME on Elections table

Author: jbriones1

src/alembic/env.py

@@ -9,7 +9,9 @@
 import blog.tables
 import database
 import elections.tables
+import nominees.tables
 import officers.tables
+import registrations.tables
 from alembic import context
 
 # this is the Alembic Config object, which provides

src/alembic/versions/6b58a293a7df_add_unique_constraint_officer_term_71.py

@@ -0,0 +1,52 @@
+"""add_unique_constraint_officer_term_71
+
+Revision ID: 6b58a293a7df
+Revises: 243190df5588
+Create Date: 2025-09-28 17:13:51.024959
+
+"""
+from collections.abc import Sequence
+
+import sqlalchemy as sa
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision: str = "6b58a293a7df"
+down_revision: str | None = "243190df5588"
+branch_labels: str | Sequence[str] | None = None
+depends_on: str | Sequence[str] | None = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column("election", "type",
+               existing_type=sa.VARCHAR(length=64),
+               nullable=False)
+    op.alter_column("officer_term", "start_date",
+               existing_type=sa.DATE(),
+               type_=sa.DateTime(),
+               existing_nullable=False)
+    op.alter_column("officer_term", "end_date",
+               existing_type=sa.DATE(),
+               type_=sa.DateTime(),
+               existing_nullable=True)
+    op.create_unique_constraint(op.f("uq_officer_term_computing_id"), "officer_term", ["computing_id", "position", "start_date"])
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.drop_constraint(op.f("uq_officer_term_computing_id"), "officer_term", type_="unique")
+    op.alter_column("officer_term", "end_date",
+               existing_type=sa.DateTime(),
+               type_=sa.DATE(),
+               existing_nullable=True)
+    op.alter_column("officer_term", "start_date",
+               existing_type=sa.DateTime(),
+               type_=sa.DATE(),
+               existing_nullable=False)
+    op.alter_column("election", "type",
+               existing_type=sa.VARCHAR(length=64),
+               nullable=True)
+    # ### end Alembic commands ###

src/elections/tables.py

@@ -25,9 +25,9 @@ class Election(Base):
     slug: Mapped[str] = mapped_column(String(MAX_ELECTION_SLUG), primary_key=True)
     name: Mapped[str] = mapped_column(String(MAX_ELECTION_NAME), nullable=False)
     type: Mapped[ElectionTypeEnum] = mapped_column(String(64), default=ElectionTypeEnum.GENERAL)
-    datetime_start_nominations: Mapped[datetime] = mapped_column(DateTime(timezone=True), nullable=False)
-    datetime_start_voting: Mapped[datetime] = mapped_column(DateTime(timezone=True), nullable=False)
-    datetime_end_voting: Mapped[datetime] = mapped_column(DateTime(timezone=True), nullable=False)
+    datetime_start_nominations: Mapped[datetime] = mapped_column(DateTime, nullable=False)
+    datetime_start_voting: Mapped[datetime] = mapped_column(DateTime, nullable=False)
+    datetime_end_voting: Mapped[datetime] = mapped_column(DateTime, nullable=False)
 
     # a comma-separated string of positions which must be elements of OfficerPosition
     # By giving it the type `StringList`, the database entry will automatically be marshalled to the correct form

src/nominees/tables.py

@@ -14,11 +14,11 @@ class NomineeInfo(Base):
     __tablename__ = "election_nominee_info"
 
     computing_id: Mapped[str] = mapped_column(String(COMPUTING_ID_LEN), primary_key=True)
-    full_name: Mapped[str] = mapped_column(String(64), nullable=False)
-    linked_in: Mapped[str] = mapped_column(String(128))
-    instagram: Mapped[str] = mapped_column(String(128))
-    email: Mapped[str] = mapped_column(String(64))
-    discord_username: Mapped[str] = mapped_column(String(DISCORD_NICKNAME_LEN))
+    full_name: Mapped[str] = mapped_column(String(64))
+    linked_in: Mapped[str] = mapped_column(String(128), nullable=True)
+    instagram: Mapped[str] = mapped_column(String(128), nullable=True)
+    email: Mapped[str] = mapped_column(String(64), nullable=True)
+    discord_username: Mapped[str] = mapped_column(String(DISCORD_NICKNAME_LEN), nullable=True)
 
     def to_update_dict(self) -> dict:
         return {

src/officers/tables.py

@@ -28,7 +28,6 @@
 class OfficerTerm(Base):
     __tablename__ = "officer_term"
 
-    # TODO (#98): create a unique constraint for (computing_id, position, start_date).
     id: Mapped[str] = mapped_column(Integer, primary_key=True, autoincrement=True)
 
     computing_id: Mapped[str] = mapped_column(
@@ -38,9 +37,9 @@ class OfficerTerm(Base):
     )
 
     position: Mapped[OfficerPositionEnum] = mapped_column(String(128), nullable=False)
-    start_date: Mapped[datetime] = mapped_column(DateTime(timezone=True), nullable=False)
+    start_date: Mapped[datetime] = mapped_column(DateTime, nullable=False)
     # end_date is only not-specified for positions that don't have a length (ie. webmaster)
-    end_date: Mapped[datetime] = mapped_column(DateTime(timezone=True), nullable=True)
+    end_date: Mapped[datetime] = mapped_column(DateTime, nullable=True)
 
     nickname: Mapped[str] = mapped_column(String(128), nullable=True)
     favourite_course_0: Mapped[str] = mapped_column(String(64), nullable=True)