fix: site users couldn't have NULL log in time

Author: jbriones1

src/alembic/versions/0a2c458d1ddd_site_user_timestamps_nullable.py

@@ -0,0 +1,40 @@
+"""site_user_timestamps_nullable
+
+Revision ID: 0a2c458d1ddd
+Revises: a5c42bcdda5c
+Create Date: 2025-09-28 20:52:02.486734
+
+"""
+from collections.abc import Sequence
+
+from sqlalchemy.dialects import postgresql
+
+from alembic import op
+
+# revision identifiers, used by Alembic.
+revision: str = "0a2c458d1ddd"
+down_revision: str | None = "a5c42bcdda5c"
+branch_labels: str | Sequence[str] | None = None
+depends_on: str | Sequence[str] | None = None
+
+
+def upgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column("site_user", "first_logged_in",
+               existing_type=postgresql.TIMESTAMP(),
+               nullable=True)
+    op.alter_column("site_user", "last_logged_in",
+               existing_type=postgresql.TIMESTAMP(),
+               nullable=True)
+    # ### end Alembic commands ###
+
+
+def downgrade() -> None:
+    # ### commands auto generated by Alembic - please adjust! ###
+    op.alter_column("site_user", "last_logged_in",
+               existing_type=postgresql.TIMESTAMP(),
+               nullable=False)
+    op.alter_column("site_user", "first_logged_in",
+               existing_type=postgresql.TIMESTAMP(),
+               nullable=False)
+    # ### end Alembic commands ###

src/auth/tables.py

@@ -37,16 +37,21 @@ class SiteUser(Base):
     )
 
     # first and last time logged into the CSSS API
-    first_logged_in: Mapped[datetime] = mapped_column(DateTime, nullable=False, server_default=func.now())
-    last_logged_in: Mapped[datetime] = mapped_column(DateTime, nullable=False, server_default=func.now())
+    first_logged_in: Mapped[datetime | None] = mapped_column(DateTime, nullable=True)
+    last_logged_in: Mapped[datetime | None] = mapped_column(DateTime, nullable=True)
 
     # optional user information for display purposes
     profile_picture_url: Mapped[str | None] = mapped_column(Text, nullable=True)
 
     def serialize(self) -> dict[str, str | int | bool | None]:
-        return {
+
+        res = {
             "computing_id": self.computing_id,
-            "first_logged_in": self.first_logged_in.isoformat(),
-            "last_logged_in": self.last_logged_in.isoformat(),
             "profile_picture_url": self.profile_picture_url
         }
+        if self.first_logged_in is not None:
+            res["first_logged_in"] = self.first_logged_in.isoformat()
+        if self.last_logged_in is not None:
+            res["last_logged_in"] = self.last_logged_in.isoformat()
+
+        return res

src/officers/crud.py

@@ -161,8 +161,8 @@ async def create_new_officer_info(
         # if computing_id has not been created as a site_user yet, add them
         db_session.add(auth.tables.SiteUser(
             computing_id=new_officer_info.computing_id,
-            first_logged_in=datetime.now(),
-            last_logged_in=datetime.now()
+            first_logged_in=None,
+            last_logged_in=None
         ))
 
     existing_officer_info = await db_session.scalar(