fix: address code review comments

Author: jbriones1

src/auth/urls.py

@@ -2,11 +2,10 @@
 import logging
 import os
 import urllib.parse
-from typing import Literal
 
 import requests  # TODO: make this async
 import xmltodict
-from fastapi import APIRouter, BackgroundTasks, Body, HTTPException, Request, Response
+from fastapi import APIRouter, BackgroundTasks,  HTTPException, Request, Response
 from fastapi.responses import JSONResponse, PlainTextResponse, RedirectResponse
 
 import database

src/constants.py

@@ -2,13 +2,13 @@
 
 # TODO(future): replace new.sfucsss.org with sfucsss.org during migration
 # TODO(far-future): branch-specific root IP addresses (e.g., devbranch.sfucsss.org)
-FRONTEND_ROOT_URL = "http://localhost:8080" if os.environ.get("LOCAL") == "true" else "https://sfucsss.org"
-GITHUB_ORG_NAME = "CSSS-Test-Organization" if os.environ.get("LOCAL") == "true" else "CSSS"
-IS_PROD = os.environ.get("LOCAL") == "false"
+ENV_LOCAL = os.environ.get("LOCAL")
+IS_PROD = False if not ENV_LOCAL or ENV_LOCAL.lower() != "true" else True
+GITHUB_ORG_NAME = "CSSS-Test-Organization" if not IS_PROD else "CSSS"
 
 W3_GUILD_ID = "1260652618875797504"
 CSSS_GUILD_ID = "228761314644852736"
-ACTIVE_GUILD_ID = W3_GUILD_ID if os.environ.get("LOCAL") == "true" else CSSS_GUILD_ID
+ACTIVE_GUILD_ID = W3_GUILD_ID if not IS_PROD else CSSS_GUILD_ID
 
 SESSION_ID_LEN = 512
 # technically a max of 8 digits https://www.sfu.ca/computing/about/support/tips/sfu-userid.html
@@ -28,5 +28,5 @@
 GITHUB_USERNAME_LEN = 39
 
 # COOKIE
-SAMESITE=None if IS_PROD else "lax"
+SAMESITE="none" if IS_PROD else "lax"
 DOMAIN=".sfucsss.org" if IS_PROD else None