clean function name

Author: EarthenSky

src/officers/constants.py

@@ -30,7 +30,10 @@ def position_list() -> list[str]:
         return _OFFICER_POSITION_LIST
 
     @staticmethod
-    def position_length_in_semesters(position: str) -> int | None:
+    def length_in_semesters(position: str) -> int | None:
+        # TODO: ask the committee to maintain a json file with all the important details from the constitution
+        # (I can create the version version of the file)
+        """How many semester position is active for, according to the CSSS Constitution"""
         return _LENGTH_MAP[position]
 
     @staticmethod

src/officers/crud.py

@@ -217,7 +217,7 @@ async def create_new_officer_term(
     if new_officer_term.position not in OfficerPosition.position_list():
         raise HTTPException(status_code=500)
 
-    position_length = OfficerPosition.position_length_in_semesters(new_officer_term.position)
+    position_length = OfficerPosition.length_in_semesters(new_officer_term.position)
     if position_length is not None:
         new_officer_term.end_date = semesters.step_semesters(
             semesters.current_semester_start(new_officer_term.start_date),