wip: removed some unused imports and updated some constraints

Author: jbriones1

src/elections/tables.py

@@ -2,7 +2,6 @@
 
 from sqlalchemy import (
     Date,
-    DateTime,
     String,
 )
 from sqlalchemy.orm import Mapped, mapped_column

src/officers/constants.py

@@ -1,5 +1,6 @@
 from enum import StrEnum
 
+OFFICER_POSITION_MAX_LENGTH = 128
 
 class OfficerPositionEnum(StrEnum):
     PRESIDENT = "president"

src/officers/models.py

@@ -18,8 +18,9 @@ class PublicOfficerResponse(BaseOfficerModel):
     """
     is_active: bool
     nickname: str | None = None
+    discord_id: str | None = None
     discord_name: str | None = None
-    discord_nickname: int | None = None
+    discord_nickname: str | None = None
     biography: str | None = None
     csss_email: str
 

src/officers/tables.py

@@ -4,7 +4,6 @@
 
 from sqlalchemy import (
     Date,
-    DateTime,
     ForeignKey,
     Integer,
     String,
@@ -21,7 +20,7 @@
     GITHUB_USERNAME_LEN,
 )
 from database import Base
-from officers.constants import OfficerPositionEnum
+from officers.constants import OFFICER_POSITION_MAX_LENGTH, OfficerPositionEnum
 
 
 # A row represents an assignment of a person to a position.
@@ -37,7 +36,7 @@ class OfficerTerm(Base):
         nullable=False,
     )
 
-    position: Mapped[OfficerPositionEnum] = mapped_column(String(128), nullable=False)
+    position: Mapped[OfficerPositionEnum] = mapped_column(String(OFFICER_POSITION_MAX_LENGTH), nullable=False)
     start_date: Mapped[datetime] = mapped_column(Date, nullable=False)
     # end_date is only not-specified for positions that don't have a length (ie. webmaster)
     end_date: Mapped[datetime] = mapped_column(Date, nullable=True)

src/officers/urls.py

@@ -5,7 +5,6 @@
 import database
 import officers.crud
 import utils
-from elections.urls import get_election_permissions
 from officers.models import PrivateOfficerResponse, PublicOfficerResponse
 from officers.tables import OfficerInfo, OfficerTerm
 from officers.types import InitialOfficerInfo, OfficerInfoUpload, OfficerTermUpload