Fix warnings (#200)

* Fix a bunch of warnings

* Fix more warnings. Some warnings aren't obvious how to fix.

* fix a bunch of downcast warnings in DATA

* fix a few more, mostly forward decls

* move forward decls to decomp_/functions.h

* unfinished stuff, doesn't compile but trying to fix warnings. RB_Hazard_HurtDriver's return type is ambiguous atm

* fix signatures and compiles

* renamed RB_Hazard_HurtDriver to DECOMP_

* fixed a bunch more warnings.

* fixed more warnings, re-decomped a couple of functions, begin D231

* fixed more warnings

* fix more warnings

* more warnings

* more warnings

* fix more warnings, changed some signatures, fixed return->return (int) for some LInC functions

* Fixed a bunch more warnings

* fixed a bunch more warnings

* Fixed a bunch more warnings, only have a few tricky ones left.

* Fixed a few more warnings

* fix some pc rebuild warnings

* fixed signature types and some local variable types

* more type fixes

* fixed a bunch more warnings, fixed missing function parameters for some callbacks

* I think that's all?

* fix road hazards and warp orbs

* fix spider web

* Update CrashTeamRacingPC.vcxproj.user

* fix a return type in signature

* fixed a warnings from the merge

* added some comments. I think the credits ghost bug is due to byteBudget/clobbering

* small changes trying to figure out the credits bug

* commit for large test

* fix another warning

* switched file naming convention for BOTS

* Fix file naming convention for more files, rewrite of byteBudget/main.py

* Fixed a bunch more naming conventions

* fix more naming schemes. ModsX.c/ModsMain.c is nonfunctional until further notice

* moving functions to rdata is causing problems, disabled the decomp for MATH_Sin, LibraryOfModels_Store, PROC_SearchForModel

* re-enable 233 cs credits functions

* update bytebudget to display more info

* fix pc port include paths

* fix naming of main functions for bytebudget

* Fix credits bug.

* fix more naming

* fix more naming conventions

* Fixed the rest of the naming in Vehicle. a couple of functions are overbudget.

* fix more naming

* repaired mods

* disable online/defrag

* disable mixrng decomp

* Decomp for MainFrame_HaveAllPads.

* re-enable mixrng getvalue

* fix 230/1 and modify byteBudget to recognize howl naming

* add comments

* add 23x entries for "FULL" bytebudget.

Author: TheUbMunster

decompile/General/221/221_Full.c

@@ -15,12 +15,6 @@ const short hub[8] =
 
 extern struct MenuRow rows221[3];
 extern struct RectMenu menu221;
-	
-int DECOMP_UI_ConvertX_2(int x, int const_0x200);
-int DECOMP_UI_ConvertY_2(int y, int const_0x200);
-void DECOMP_UI_DrawNumCrystal(short x, short y, struct Driver* d);
-void RECTMENU_ClearInput();
-void RECTMENU_Show(struct RectMenu*);
 
 void DECOMP_CC_EndEvent_DrawMenu()
 {

decompile/General/222/222_Full.c

@@ -3,8 +3,6 @@
 static int str_number = 0x20; // " \0"
 extern struct RectMenu menu222;
 
-void DECOMP_AA_EndEvent_DisplayTime(short driverId, short param_2);
-
 void DECOMP_AA_EndEvent_DrawMenu(void)
 {
 	struct GameTracker *gGT;
@@ -315,7 +313,7 @@ void DECOMP_AA_EndEvent_DrawMenu(void)
 
 			// print a single character, a number 1-8,
 			DecalFont_DrawLine(
-				&str_number, letterPos[0] + 0x20, 0x5f, 2, 4);
+				(char*)&str_number, letterPos[0] + 0x20, 0x5f, 2, 4);
 
 			// Draw the driver's character icon
 			DECOMP_UI_DrawDriverIcon(

decompile/General/223/223_Full.c

@@ -7,9 +7,6 @@
 // this goes to footer
 static int str_number = 0x20; // " \0"
 
-void DECOMP_RR_EndEvent_UnlockAward();
-void DECOMP_RR_EndEvent_DrawHighScore(short startX, int startY);
-
 // required to start on 8009f71c until we rewrite MainGameEnd_Initialize
 void JunkPadding223()
 {
@@ -606,7 +603,7 @@ void DECOMP_RR_EndEvent_DrawHighScore(short startX, int startY)
 		str_number = (char)i + '1';
 
 		// Draw String for Rank ('1', '2', '3', '4', '5')
-		DecalFont_DrawLine(&str_number, startX - 0x32, timebox_Y - 1, 2, 4);
+		DecalFont_DrawLine((char*)&str_number, startX - 0x32, timebox_Y - 1, 2, 4);
 
 		u_int iconColor = 0x808080;
 

decompile/General/224/224_Full.c

@@ -7,8 +7,6 @@ extern struct RectMenu menu224;
 extern struct MenuRow rowsWithSave[6];
 extern struct MenuRow rowsNoSave[5];
 
-void DECOMP_TT_EndEvent_DisplayTime(int paramX, short paramY, u_int UI_DrawRaceClockFlags);
-
 void DECOMP_TT_EndEvent_DrawMenu(void)
 {
     int framesSinceRaceEnded;
@@ -412,7 +410,7 @@ void DECOMP_TT_EndEvent_DrawHighScore(short startX, int startY)
 		str_number = (char)i + '1';
 
 		// Draw String for Rank ('1', '2', '3', '4', '5')
-		DecalFont_DrawLine(&str_number, startX - 0x32, timebox_Y - 1, 2, 4);
+		DecalFont_DrawLine((char*)&str_number, startX - 0x32, timebox_Y - 1, 2, 4);
 
 		u_int iconColor = 0x808080;
 

decompile/General/225/225_Full.c

@@ -41,7 +41,6 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
   short sVar9;
   int iVar10;
   int iVar11;
-  u_int uVar13;
   int iVar14;
   u_short uStack112;
   short sStack104;
@@ -76,6 +75,7 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
   // lng index for BATTLE
   iVar10 = 0x50;
 
+  short yCoord;
   // if you are not in battle mode
   if ((gGT->gameMode1 & 0x20) == 0)
   {
@@ -85,7 +85,7 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
     // number of battle teams
     uStack96 = numPlyr;
 
-    uVar13 = VsPosY_Config[VsPosY_NUM*VsConfigIndex + VsPosY_TITLE];
+	yCoord = VsPosY_Config[VsPosY_NUM*VsConfigIndex + VsPosY_TITLE];
   }
   // if you are in battle mode
   else
@@ -100,7 +100,7 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
       asStack128[gGT->drivers[iVar11]->BattleHUD.teamID]++;
     }
 
-    uVar13 = 0xd8 - ((gGT->battleSetup.numTeams + -1) * 10 + numPlyr * 0x1a + 0x28) >> 1;
+	yCoord = 0xd8 - ((gGT->battleSetup.numTeams + -1) * 10 + numPlyr * 0x1a + 0x28) >> 1;
   }
 
   // Disable drawing lines between multiplayer screens
@@ -123,11 +123,11 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
   // fly-in interpolation
   DECOMP_UI_Lerp2D_Linear(
 	&pos[0],
-	0x296, uVar13,
-	uVar7, uVar13,
+	0x296, yCoord,
+	uVar7, yCoord,
 	iVar11, FPS_DOUBLE(5));
 
-  iVar14 = uVar13 + 0x28;
+  iVar14 = yCoord + 0x28;
 
   // "Versus" or "Battle"
   DecalFont_DrawLine(
@@ -263,12 +263,13 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
           iVar2 = iVar10 + 1;
 
           // string for each player rank and count from standings (0x1e80)
-          sprintf(0x1f800000, "%d%s-%2.02ld", iVar2,
+          sprintf((char*)0x1f800000, "%d%s-%2.02ld", iVar2, //todo: replace 0x1f800000 with reference to scratchpad
                   sdata->lngStrings[0x19+iVar10],
                   (gGT->standingsPoints[gGT->battleSetup.unk1dc8[iVar11] * 3 + iVar10]));
 
           // Draw string
-          DecalFont_DrawLine(0x1f800000, (pos[0] + 0x79), ((uStack112 - (iVar6 * 4 + -0xd)) + iVar10 * 8), 2, uVar7);
+		  //todo: replace 0x1f800000 with reference to scratchpad
+          DecalFont_DrawLine((char*)0x1f800000, (pos[0] + 0x79), ((uStack112 - (iVar6 * 4 + -0xd)) + iVar10 * 8), 2, uVar7);
         }
       }
 
@@ -291,18 +292,20 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
       iStack44 = iStack44 + FPS_DOUBLE(5);
 
 	  sStack80 = gGT->battleSetup.unk_afterTeams[gGT->battleSetup.unk1dc8[iVar11]];
-      sprintf(0x1f800000, "%d%s", sVar1 + 1, sdata->lngStrings[0x19+sVar1]);
+	  //todo: replace 0x1f800000 with reference to scratchpad
+      sprintf((char*)0x1f800000, "%d%s", sVar1 + 1, sdata->lngStrings[0x19+sVar1]);
 
       // Draw String
-      DecalFont_DrawLine(0x1f800000, (pos[0] - 0x24), (uStack112 + 5), 1, 0xffff8000);
+	  //todo: replace 0x1f800000 with reference to scratchpad
+      DecalFont_DrawLine((char*)0x1f800000, (pos[0] - 0x24), (uStack112 + 5), 1, 0xffff8000);
     }
   }
 
-  for (uVar13 = 0; uVar13 < numPlyr; uVar13++)
+  for (unsigned char plCount = 0; plCount < (unsigned char)numPlyr; plCount++)
   {
     // get pointer to instance of Big Number in HUD
-    bigNum = gGT->drivers[uVar13]->instBigNum;
-    view = &gGT->pushBuffer[uVar13];
+    bigNum = gGT->drivers[plCount]->instBigNum;
+    view = &gGT->pushBuffer[plCount];
 
     // if the pointer is valid
     if (bigNum != NULL)
@@ -319,7 +322,7 @@ void DECOMP_VB_EndEvent_DrawMenu(void)
       // if this is not battle mode, get first place racer, else get battle winner
       uVar3 = ((gGT->gameMode1 & 0x20) == 0) ? gGT->driversInRaceOrder[0]->driverID : gGT->winnerIndex[0];
 
-      if (uVar3 != uVar13)
+      if (uVar3 != plCount)
         goto LAB_8009ff4c;
 
 	  // === PushBuffer is the winner ===

decompile/General/230/230_Block1.c …230_00_38_MM_Battle_DrawIcon_Character.cdecompile/General/230/230_Block1.c renamed to decompile/General/230/230_00_38_MM_Battle_DrawIcon_Character.c decompile/General/230/230_Block1.c renamed to decompile/General/230/230_00_38_MM_Battle_DrawIcon_Character.c

@@ -125,7 +125,7 @@ void DECOMP_MM_Title_MenuUpdate(void)
   case 0:
 
     DECOMP_MM_Title_KillThread();
-    DECOMP_GAMEPROG_NewProfile_InsideAdv(&sdata->advProgress.rewards);
+    DECOMP_GAMEPROG_NewProfile_InsideAdv(&sdata->advProgress);
 
     sdata->advProfileIndex = 0xffff;
 

decompile/General/230/230_02_MM_Title_MenuUpdate.c

@@ -125,8 +125,7 @@ void DECOMP_MM_Characters_DrawWindows(int boolShowDrivers)
 
 	iVar6 = iVar14;
 
-	struct InstDrawPerPlayer* idpp =
-		INST_GETIDPP(iVar10);
+	struct InstDrawPerPlayer* idpp = INST_GETIDPP(iVar10);
 
     // clear pushBuffer in every InstDrawPerPlayer
     idpp[0].pushBuffer = 0;
@@ -215,7 +214,7 @@ void DECOMP_MM_Characters_DrawWindows(int boolShowDrivers)
     rot[2] = D230.csm_instRot[2];
 
 	// converted to TEST in rebuildPS1
-    ConvertRotToMatrix(&iVar10->matrix.m[0][0], &rot[0]);
+    ConvertRotToMatrix(&iVar10->matrix, &rot[0]);
   }
   return;
 }