Skip to content

Commit 0278910

Browse files
JDevliegherejrtc27
authored andcommitted
[test] Add a FIXME test for stop-command-source-on-error
Modifying the interpreter settings is tricky because they don't take effect until we create a new command interpreter, which should be merely an implementation detail. This leads to confusing and unexpected scenarios. This adds a test cases with FIXMEs for some of the odd scenarios I encountered. I didn't XFAIL the test because I don't think there's a way to get an unexpected PASS if any of the commands succeeds and splitting up the file in multiple tests seems excessive. llvm-svn: 371259
2 parents 8059ade + 92ada4a commit 0278910

File tree

3 files changed

+30
-0
lines changed

3 files changed

+30
-0
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
settings set interpreter.stop-command-source-on-error false
2+
bogus
3+
print 123400000 + 56789
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
settings set interpreter.stop-command-source-on-error true
2+
bogus
3+
print 123400000 + 56789
Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Modifying the interpreter settings is tricky because they don't take effect
2+
# until we create a new command interpreter, which should be merely an
3+
# implementation detail. This leads to confusing and unexpected scenarios.
4+
#
5+
# Below are a few scenarios that we should fix.
6+
7+
# CONTINUE: 123456789
8+
# STOP-NOT: 111111111
9+
# STOP-NOT: 123456789
10+
11+
# FIXME: Should stop
12+
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -s %S/Inputs/StopCommandSource.in | FileCheck %s --check-prefix CONTINUE
13+
14+
# FIXME: Should continue
15+
# RUN: %lldb -b -s %S/Inputs/DontStopCommandSource.in -o 'bogus' -o 'print 111100000 + 11111' | FileCheck %s --check-prefix STOP
16+
17+
# FIXME: Should continue
18+
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error false' -o 'bogus' -o 'print 123400000 + 56789' | FileCheck %s --check-prefix STOP
19+
20+
# FIXME: Should continue
21+
# RUN: %lldb -b -s %S/Inputs/DontStopCommandSource.in | FileCheck %s --check-prefix STOP
22+
23+
# FIXME: Should continue
24+
# RUN: %lldb -b -o 'settings set interpreter.stop-command-source-on-error true' -s %S/Inputs/DontStopCommandSource.in | FileCheck %s --check-prefix STOP

0 commit comments

Comments
 (0)