[NFC][ELF][CHERI] Fix a set but not used warning#804
Merged
bsdjhb merged 1 commit intoCTSRD-CHERI:devfrom Jan 23, 2026
Merged
Conversation
lld/ELF/Arch/Cheri.cpp:496:17: warning: variable 's' set but not used [-Wunused-but-set-variable]
496 | if (Symbol *s = dyn_cast<Symbol *>(realTarget.symOrSec))
| ^
Fixes: b9963fa ("[ELF][CHERI] Add new getTargetType to separate encoding from classification")
jrtc27
approved these changes
Jan 22, 2026
Member
jrtc27
left a comment
jrtc27
left a comment
There was a problem hiding this comment.
Not sure how I missed that with how many times I must have compiled these files :( hopefully down to my particular environment not warning rather than blindness…
Contributor
Author
|
It wasn't a fatal warning and I only noticed it by chance while working on the c18n branch myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lld/ELF/Arch/Cheri.cpp:496:17: warning: variable 's' set but not used [-Wunused-but-set-variable]
496 | if (Symbol *s = dyn_cast<Symbol *>(realTarget.symOrSec))
| ^
Fixes: b9963fa ("[ELF][CHERI] Add new getTargetType to separate encoding from classification")