Skip to content

Commit d0c1f33

Browse files
Stuart Menefyarichardson
authored andcommitted
riscv: hobgoblin: Simplify UART in generated DT
Kernel device trees have removed the "reg-offset" parameter from the 16550 UART, and adjusted the base to compensate. Make the same changes to the generated DT.
1 parent c6aebf3 commit d0c1f33

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

hw/riscv/hobgoblin.c

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -858,8 +858,7 @@ static void create_fdt_aliases(HobgoblinState *s, const memmapEntry_t *memmap)
858858
qemu_fdt_setprop_string(mc->fdt, name, "ethernet1", ethernet1_alias);
859859

860860
serial0_alias =
861-
g_strdup_printf("/soc@0/serial@%lx", memmap[HOBGOBLIN_UART0].base -
862-
memmap[HOBGOBLIN_UART0].size);
861+
g_strdup_printf("/soc@0/serial@%lx", memmap[HOBGOBLIN_UART0].base);
863862
qemu_fdt_setprop_string(mc->fdt, name, "serial0", serial0_alias);
864863

865864
spi0_alias = g_strdup_printf("/soc@0/spi@%lx", memmap[HOBGOBLIN_SPI].base);
@@ -1474,8 +1473,7 @@ static void create_fdt_uart(HobgoblinState *s, const memmapEntry_t *memmap,
14741473
MachineState *mc = MACHINE(s);
14751474

14761475
name =
1477-
g_strdup_printf("/soc@0/serial@%lx", memmap[HOBGOBLIN_UART0].base -
1478-
memmap[HOBGOBLIN_UART0].size);
1476+
g_strdup_printf("/soc@0/serial@%lx", memmap[HOBGOBLIN_UART0].base);
14791477
qemu_fdt_add_subnode(mc->fdt, name);
14801478
qemu_fdt_setprop_cell(
14811479
mc->fdt, name, "clock-frequency",
@@ -1489,11 +1487,8 @@ static void create_fdt_uart(HobgoblinState *s, const memmapEntry_t *memmap,
14891487
qemu_fdt_setprop(mc->fdt, name, "interrupts-extended", interrupts_extended0,
14901488
sizeof(interrupts_extended0));
14911489
qemu_fdt_setprop_cells(mc->fdt, name, "reg",
1492-
memmap[HOBGOBLIN_UART0].base -
1493-
memmap[HOBGOBLIN_UART0].size,
1494-
memmap[HOBGOBLIN_UART0].size + 32);
1495-
qemu_fdt_setprop_cell(mc->fdt, name, "reg-offset",
1496-
memmap[HOBGOBLIN_UART0].size);
1490+
memmap[HOBGOBLIN_UART0].base,
1491+
memmap[HOBGOBLIN_UART0].size);
14971492
qemu_fdt_setprop_cell(mc->fdt, name, "reg-shift", 2);
14981493
g_free(name);
14991494

0 commit comments

Comments
 (0)