File tree Expand file tree Collapse file tree 3 files changed +1
-31
lines changed
Expand file tree Collapse file tree 3 files changed +1
-31
lines changed Original file line number Diff line number Diff line change @@ -128,7 +128,7 @@ impl MemoryCatalog {
128128 config : MemoryCatalogConfig ,
129129 storage_factory : Option < Arc < dyn StorageFactory > > ,
130130 ) -> Result < Self > {
131- // Use provided factory or default to MemoryStorageFactory
131+ // Use provided factory or default to LocalFsStorageFactory
132132 let factory = storage_factory. unwrap_or_else ( || Arc :: new ( LocalFsStorageFactory ) ) ;
133133
134134 Ok ( Self {
Original file line number Diff line number Diff line change @@ -199,19 +199,6 @@ pub struct FileIOBuilder {
199199
200200impl FileIOBuilder {
201201 /// Creates a new builder with the given storage factory.
202- ///
203- /// # Arguments
204- ///
205- /// * `factory` - The storage factory to use for creating storage instances
206- ///
207- /// # Example
208- ///
209- /// ```rust,ignore
210- /// use iceberg::io::{FileIOBuilder, LocalFsStorageFactory};
211- /// use std::sync::Arc;
212- ///
213- /// let builder = FileIOBuilder::new(Arc::new(LocalFsStorageFactory));
214- /// ```
215202 pub fn new ( factory : Arc < dyn StorageFactory > ) -> Self {
216203 Self {
217204 factory,
@@ -242,9 +229,6 @@ impl FileIOBuilder {
242229 }
243230
244231 /// Builds [`FileIO`].
245- ///
246- /// Note: Storage is lazily initialized on first use, so this method
247- /// does not return a Result.
248232 pub fn build ( self ) -> FileIO {
249233 FileIO {
250234 config : self . config ,
Original file line number Diff line number Diff line change @@ -122,20 +122,6 @@ mod tests {
122122 }
123123 }
124124
125- #[ test]
126- fn test_file_io_builder_extension_system ( ) {
127- // Test adding and retrieving extensions
128- // Note: Extension system is not part of the new FileIOBuilder API
129- // This test is removed as the extension system was part of the old API
130- }
131-
132- #[ test]
133- fn test_file_io_builder_multiple_extensions ( ) {
134- // Test adding multiple different types of extensions
135- // Note: Extension system is not part of the new FileIOBuilder API
136- // This test is removed as the extension system was part of the old API
137- }
138-
139125 #[ test]
140126 fn test_custom_aws_credential_loader_instantiation ( ) {
141127 // Test creating CustomAwsCredentialLoader with mock loader
You can’t perform that action at this time.
0 commit comments