Skip to content

Commit 7dc4b21

Browse files
committed
fixed an unneccessary memory use in segmented_max_back
1 parent 5b0d041 commit 7dc4b21

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/aggregations/segmented_max.jl

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,19 @@ function segmented_max_back(Δ, y, x, ψ, bags)
6767
end
6868
else
6969
fi = first(b)
70-
v .= x[:,fi]
70+
for k in axes(v,1)
71+
v[k] = x[k,fi]
72+
end
7173
idxs .= fi
7274
for j in b
73-
for i in 1:size(x,1)
75+
for i in axes(x,1)
7476
if v[i] < x[i, j]
7577
idxs[i] = j
7678
v[i] = x[i, j]
7779
end
7880
end
7981
end
80-
for i in 1:size(x, 1)
82+
for i in axes(x,1)
8183
dx[i, idxs[i]] += Δ[i, bi]
8284
end
8385
end

0 commit comments

Comments
 (0)