Various small fixes and clean up

Author: david-rocca

src/controller/org.controller/index.js

@@ -1004,7 +1004,10 @@ router.post(
   */
   mw.validateUser,
   mw.onlySecretariat,
-  body(['short_name']).isString().trim().notEmpty().isLength({ min: CONSTANTS.MIN_SHORTNAME_LENGTH, max: CONSTANTS.MAX_SHORTNAME_LENGTH }),
+  body(['short_name'])
+    .isString().withMessage(errorMsgs.MUST_BE_STRING).trim()
+    .notEmpty().withMessage(errorMsgs.NOT_EMPTY)
+    .isLength({ min: CONSTANTS.MIN_SHORTNAME_LENGTH, max: CONSTANTS.MAX_SHORTNAME_LENGTH }).withMessage(errorMsgs.SHORTNAME_LENGTH),
   body(['name']).isString().trim().notEmpty(),
   body(['authority.active_roles']).optional()
     .custom(isFlatStringArray)
@@ -1178,6 +1181,7 @@ router.put('/org/:shortname',
   parseError,
   parsePostParams,
   controller.ORG_UPDATE_SINGLE)
+
 router.get('/org/:shortname/id_quota',
   /*
   #swagger.tags = ['Organization']

src/middleware/errorMessages.js

@@ -3,6 +3,9 @@
 module.exports = {
   ORG_ROLES: 'Invalid role. Valid roles are CNA, SECRETARIAT',
   USER_ROLES: 'Invalid role. Valid role is ADMIN',
+  NOT_EMPTY: 'Value must not be empty',
+  SHORTNAME_LENGTH: 'Value must be between 2 and 20 characters in length.',
+  MUST_BE_STRING: 'Value must be a string',
   ID_QUOTA: 'The id_quota does not comply with CVE id quota limitations',
   ID_STATES: 'Invalid CVE ID state. Valid states are: RESERVED, PUBLISHED, REJECTED',
   ID_MODIFY_STATES: 'Invalid CVE ID state. Valid states are: RESERVED, REJECTED',

src/repositories/baseOrgRepository.js

@@ -35,6 +35,12 @@ function setAggregateRegistryOrgObj (query) {
   return [
     {
       $match: query
+    },
+    {
+      $project: {
+        _id: false,
+        __t: false
+      }
     }
   ]
 }