Skip to content

Commit 4cc8e65

Browse files
committed
removed incorrect throw documentation
1 parent 23c07d4 commit 4cc8e65

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

src/controller/org.controller/org.controller.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,10 @@ async function getOrg (req, res, next) {
6767
returnValue = await repo.getOrg(identifier, identifierIsUUID, { session }, !req.useRegistry)
6868
} catch (error) {
6969
await session.abortTransaction()
70+
// Handle the specific error thrown by BaseOrgRepository.createOrg
71+
if (error.message && error.message.includes('Unknown Org type requested')) {
72+
return res.status(400).json({ message: error.message })
73+
}
7074
throw error
7175
} finally {
7276
await session.endSession()

src/controller/registry-org.controller/registry-org.controller.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,9 @@ async function createOrg (req, res, next) {
161161
await session.commitTransaction()
162162
} catch (createErr) {
163163
await session.abortTransaction()
164+
if (createErr.message && createErr.message.includes('Unknown Org type requested')) {
165+
return res.status(400).json({ message: createErr.message })
166+
}
164167
throw createErr
165168
} finally {
166169
await session.endSession()

src/repositories/baseOrgRepository.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,8 @@ class BaseOrgRepository extends BaseRepository {
250250
await reviewObjectRepo.createReviewOrgObject(registryObjectRaw, { options })
251251
}
252252
} else {
253-
// eslint-disable-next-line no-throw-literal
254-
throw 'dave you screwed up'
253+
// Throw an Error instance so callers can catch and handle it properly
254+
throw new Error("Unknown Org type requested. Please use either 'SECRETARIAT', 'CNA', 'ADP', or 'BULK_DOWNLOAD' as the authority role.")
255255
}
256256

257257
// ADD AUDIT ENTRY AUTOMATICALLY for the registry object

0 commit comments

Comments
 (0)