Skip to content

Commit d175a77

Browse files
committed
Javascript do be passing by reference
1 parent 007d7b9 commit d175a77

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

src/controller/cve.controller/cve.controller.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ const convertDatesToISO = require('../../utils/utils').convertDatesToISO
88
const isEnrichedContainer = require('../../utils/utils').isEnrichedContainer
99
const url = process.env.NODE_ENV === 'staging' ? 'https://test.cve.org/' : 'https://cve.org/'
1010

11+
const _ = require('lodash')
12+
1113
// Helper function to create providerMetadata object
1214
function createProviderMetadata (orgId, shortName, updateDate) {
1315
return { orgId: orgId, shortName: shortName, dateUpdated: updateDate }
@@ -353,7 +355,7 @@ async function submitCve (req, res, next) {
353355

354356
// check that cve id exists
355357
let result = await cveIdRepo.findOneByCveId(id)
356-
const oldCveID = result
358+
const oldCveID = _.cloneDeep(result)
357359
if (!result || result.state === CONSTANTS.CVE_STATES.AVAILABLE) {
358360
return res.status(403).json(error.cveDne())
359361
}
@@ -420,7 +422,7 @@ async function updateCve (req, res, next) {
420422
logger.info(cveId + ' does not exist.')
421423
return res.status(403).json(error.cveDne())
422424
}
423-
const oldCveID = result
425+
const oldCveID = _.cloneDeep(result)
424426

425427
result = await cveRepo.findOneByCveId(cveId)
426428
if (!result) {
@@ -765,7 +767,7 @@ async function rejectExistingCve (req, res, next) {
765767
}
766768

767769
// old cve record
768-
const oldCveRecord = result
770+
const oldCveRecord = _.cloneDeep(result)
769771
// update CVE record to rejected
770772
const updatedRecord = Cve.updateCveToRejected(id, providerMetadata, result.cve, req.ctx.body)
771773
const updatedCve = new Cve({ cve: convertDatesToISO(updatedRecord, CONSTANTS.DATE_FIELDS) })

0 commit comments

Comments
 (0)