re-wrote the for loop to correctly terminate on the return

Author: david-rocca

src/controller/org.controller/org.controller.js

@@ -450,34 +450,42 @@ async function createUser (req, res, next) {
       return res.status(400).json(error.userLimitReached())
     }
 
-    Object.keys(req.ctx.body).forEach(k => {
-      const key = k.toLowerCase()
+    const body = req.ctx.body
+    const keys = Object.keys(body)
 
-      if (key === 'username') {
-        newUser.username = req.ctx.body.username
-      } else if (key === 'authority') {
-        if (req.ctx.body.authority.active_roles) {
-          newUser.authority.active_roles = [...new Set(req.ctx.body.authority.active_roles)] // Removes any duplicate strings from array
-        }
-      } else if (key === 'name') {
-        if (req.ctx.body.name.first) {
-          newUser.name.first = req.ctx.body.name.first
-        }
-        if (req.ctx.body.name.last) {
-          newUser.name.last = req.ctx.body.name.last
-        }
-        if (req.ctx.body.name.middle) {
-          newUser.name.middle = req.ctx.body.name.middle
-        }
-        if (req.ctx.body.name.suffix) {
-          newUser.name.suffix = req.ctx.body.name.suffix
-        }
-      } else if (key === 'org_uuid') {
-        return res.status(400).json(error.uuidProvided('org'))
-      } else if (key === 'uuid') {
+    for (const keyRaw of keys) {
+      const key = keyRaw.toLowerCase()
+
+      if (key === 'uuid') {
         return res.status(400).json(error.uuidProvided('user'))
       }
-    })
+
+      if (key === 'org_uuid') {
+        return res.status(400).json(error.uuidProvided('org'))
+      }
+
+      const handlers = {
+        username: () => {
+          newUser.username = body.username
+        },
+        authority: () => {
+          if (body.authority?.active_roles) {
+            newUser.authority.active_roles = [...new Set(body.authority.active_roles)]
+          }
+        },
+        name: () => {
+          const name = body.name || {}
+          if (name.first) newUser.name.first = name.first
+          if (name.last) newUser.name.last = name.last
+          if (name.middle) newUser.name.middle = name.middle
+          if (name.suffix) newUser.name.suffix = name.suffix
+        }
+      }
+
+      if (handlers[key]) {
+        handlers[key]() // execute the appropriate handler
+      }
+    }
 
     const requesterOrgUUID = await orgRepo.getOrgUUID(requesterShortName)
     const isSecretariat = await orgRepo.isSecretariatUUID(requesterOrgUUID)