cveListSearch: fix getIdData(), handle missing data in getSearchResults()

Author: rlxdev

src/stores/cveListSearch.js

@@ -29,7 +29,6 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
       showHelpText: false,
       size: 25,
       totalExecutingRequests: -1,
-      totalSearchResultCount: 0,
       pagination: {
         startWindow: 1,
         endWindow: undefined,
@@ -65,6 +64,9 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
       },
     }
   },
+  getters: {
+    totalSearchResultCount: (state) => state.searchResults.length
+  },
   actions: {
     decrement(field) {
       this[field] -= 1;
@@ -74,7 +76,6 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
     },
     resetResults() {
       this.searchResults = [];
-      this.totalSearchResultCount = 0;
     },
     async search() {
       this.isSearching = true;
@@ -97,9 +98,8 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
         // if record is not found, find potential reserved/rejected ID
         if (this.isCveIdPattern() && Object.keys(this.recordData).length === 0) {
           await this.getIdData();
-        }
-
-        throw new Error('search() >> error with getSearchResults(), getRecordData(), or getIdData()');
+        } else
+          throw new Error(`search() >> error with getSearchResults(), getRecordData(): ${error}`);
       } finally {
         this.isSearching = false;
         this.setUpInitialPagination();
@@ -123,7 +123,7 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
           cna: cveRecordData?.containers?.cna?.providerMetadata?.shortName || 'No CNA provided',
           cnaOrgId: cveRecordData?.containers?.cna?.providerMetadata?.orgId || '',
           descriptions: descriptions,
-          relevancyScore: 'not appliciable'
+          relevancyScore: 'not applicable'
         }
         this.recordData = recordDataSummary;
 
@@ -151,15 +151,15 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
       const getIdUrl = `${useGenericGlobalsStore().currentServicesUrl}/api/cve-id/${this.cveId}`;
       try {
         const response = await axios.get(getIdUrl);
-        const idData = response || {};
+        const idData = response.data ?? {};
         this.isIdOrRecordFound = true;
         this.isAnId = true;
-        if (idData.status === 200 && idData?.data?.error === undefined) {
-          this.idData = idData.data;
+        if (response.status === 200 && response.data?.error === undefined) {
+          this.idData = idData;
           if (idData.state === 'RESERVED') {
             this.isReserved = true;
             this.isArecord = false;
-          } else if (this.$store.state.idData.state === 'REJECTED') {
+          } else if (idData.state === 'REJECTED') {
             this.isRejected = true;
             this.isArecord = false;
           }
@@ -176,32 +176,44 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
       this.resetResults();
 
       try {
+        const ems = useErrorMessageStore();
         let payLoad = this.createSearchPayload();
         const response = await axios.post(searchUrl, payLoad);
 
-        const searchMetaData = response.data.searchMetadata;
+        if (!response.data) {
+
+          // This shouldn't happen, but it has so it's possible.  This is
+          // different from a successful search with no results - the service
+          // returned nothing in the 'data' field.  Rather than ignore it,
+          // indicate with a message that nothing was returned.  The problem may
+          // be that the service can't handle something in the input string.
+
+          ems.pushErrorMessage('No response data from search - check input');
 
-        if (searchMetaData.searchStatus === 'ok') {
-          this.totalSearchResultCount = response.data.resultsTotal;
-          this.processSearchResults(response.data.data);
         } else {
-          // There's likely something invalid in the search string.
-          // Error message(s) and note(s) returned in the response will be
-          // displayed to the user.
-          //
-          // We could reset the error message store here, because this is a
-          // "new" search, but resetting may also mask an issue where the
-          // search is inadvertently done multiple times (resulting in
-          // duplicate error messages displayed).
-
-          const ems = useErrorMessageStore();
-
-          searchMetaData.errors.forEach(e => ems.pushErrorMessage(e.message));
-          searchMetaData.notes.forEach(n => ems.pushErrorMessage(n));
+
+          const searchMetaData = response.data.searchMetadata;
+
+          if (searchMetaData.searchStatus === 'ok') {
+            this.processSearchResults(response.data.data);
+          } else {
+            // There's likely something invalid in the search string.
+            // Error message(s) and note(s) returned in the response will be
+            // displayed to the user.
+            //
+            // We could reset the error message store here, because this is a
+            // "new" search, but resetting may also mask an issue where the
+            // search is inadvertently done multiple times (resulting in
+            // duplicate error messages displayed).
+
+            searchMetaData.errors.forEach(e => ems.pushErrorMessage(e.message));
+            searchMetaData.notes.forEach(n => ems.pushErrorMessage(n));
+          }
         }
       } catch (e) {
         this.isSearchServerError = true;
-        throw new Error(`getSearchResults >> : ${e}`)
+        if (e.code !== 'ERR_NETWORK')
+          throw new Error(`getSearchResults >> : ${e}`);
       } finally {
         this.isQueryingSearchService = false;
         this.decrement('totalExecutingRequests');
@@ -210,7 +222,7 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
     processSearchResults(results){
       const parsedResults = [];
 
-      if (results.length >> 0) {
+      if (results.length > 0) {
         results.forEach((result) => {
           parsedResults.push({
             cveId: result._id,
@@ -228,13 +240,17 @@ export const useCveListSearchStore = defineStore('cveListSearch ', {
       let descriptions = [];
       if (recordData.cveMetadata?.state === "PUBLISHED") {
         recordData.containers?.cna?.descriptions.forEach((description) => {
-          if (this.isEnglishLanguage(description.lang)) descriptions.push(this.processShowMoreShowLessDescription(description.value));
+          if (this.isEnglishLanguage(description.lang))
+            descriptions.push(this.processShowMoreShowLessDescription(description.value));
         });
       } else if (recordData.cveMetadata?.state === "REJECTED") {
         recordData.containers?.cna?.rejectedReasons.forEach((rejectedReason) => {
-          if (this.isEnglishLanguage(rejectedReason.lang)) descriptions.push(this.processShowMoreShowLessDescription(rejectedReason.value));
+          if (this.isEnglishLanguage(rejectedReason.lang))
+            descriptions.push(this.processShowMoreShowLessDescription(rejectedReason.value));
         });
-      } else { // resevered/rejected ID w/o a CVE record does not have description, and that logic is handled in corresponding Vue file
+      } else {
+        // reserved/rejected ID w/o a CVE record does not have description, and
+        // that logic is handled in corresponding Vue file
         descriptions.push('No description provided');
       }