Skip to content

Commit cb9dc86

Browse files
committed
Minor text cleanup and link files to warnings about binding redirects
1 parent 77bb72c commit cb9dc86

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

src/MSBuild.SDK.SystemWeb/Sdk/MSBuild.SDK.SystemWeb.BindingRedirects.targets

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
====================================================================================================
33
44
GenerateBindingRedirects Behaviors
5-
5+
66
Traditionally (Microsoft.Common.CurrentVersion.targets) only Performs BindingRedirect calculations when
77
Project type is deemed to "need" redirects -> when OutputType == 'exe' or OutputType == 'winexe' (Microsoft.Common.CurrentVersion.targets)
88
AND
@@ -12,7 +12,7 @@
1212
A newer Full Framework project TargetFrameworkIdentifier == '.NETFramework' and '$(TargetFrameworkVersion.TrimStart(vV))' >= '4.7.2' (Microsoft.Common.CurrentVersion.targets)
1313
Additionally it chooses the filename of the config file to be updated as what exe projects want...
1414
$(IntermediateOutputPath)$(TargetFileName).config -> the config file named after the assembly and in the IntermediateOutputPath
15-
15+
1616
https://github.com/CZEMacLeod/MSBuild.SDK.SystemWeb/issues/34
1717
This SDK Project Type will override these settings so that we can facilitate developers working with BindingRedirects in the web.config
1818
Enable the Build Process to calculate Binding Redirects
@@ -22,7 +22,7 @@
2222
OverwriteAppConfigWithBindingRedirects -> this is the SystemWeb Sdk Legacy property
2323
GeneratedBindingRedirectsAction (Overwrite) -> this will conditionally change wich config file is written to
2424
====================================================================================================
25-
-->
25+
-->
2626

2727
<Project>
2828

@@ -31,7 +31,7 @@
3131
<AutoGenerateBindingRedirects Condition=" '$(AutoGenerateBindingRedirects)' == '' ">true</AutoGenerateBindingRedirects>
3232
</PropertyGroup>
3333

34-
<PropertyGroup Label="Set the desire default behavior of what to do with SuggestedBindingRedirects if not yet set"
34+
<PropertyGroup Label="Set the desired default behavior of what to do with SuggestedBindingRedirects if not yet set"
3535
Condition=" '$(GeneratedBindingRedirectsAction)' == ''">
3636
<GeneratedBindingRedirectsAction>None</GeneratedBindingRedirectsAction>
3737
<GeneratedBindingRedirectsAction Condition=" '$(OverwriteAppConfigWithBindingRedirects)' != 'true' ">Preview</GeneratedBindingRedirectsAction>
@@ -56,8 +56,8 @@
5656
5757
In general we want to emit a "warning" whenever we either do, or don't do something to help developers find the property that drives this behavior
5858
====================================================================================================
59-
-->
60-
<Target Name="SystemWebProject_ChooseConfigFileForGenerateBindingRedirects"
59+
-->
60+
<Target Name="SystemWebProject_ChooseConfigFileForGenerateBindingRedirects"
6161
BeforeTargets="GenerateBindingRedirects"
6262
Condition="'$(AutoGenerateBindingRedirects)' == 'true' and '$(GenerateBindingRedirectsOutputType)' == 'true' and @(SuggestedBindingRedirects->Count()) > 0 ">
6363

@@ -67,16 +67,16 @@
6767
</PropertyGroup>
6868

6969
<Warning Condition="'$(GeneratedBindingRedirectsAction)' != 'Preview' and '$(GeneratedBindingRedirectsAction)' != 'Overwrite'"
70-
Text="Generated Binding Redirects have been applied only to the $(TargetFileName).config. You should incorporate them into the web.config. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Preview&lt;/GeneratedBindingRedirectsAction&gt; to create a file containing the proposals. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Overwrite&lt;/GeneratedBindingRedirectsAction&gt; to automatically update web.config with proposals." />
70+
File="$(TargetFileName).config"
71+
Text="Generated Binding Redirects have been applied only to the $(TargetFileName).config. You should incorporate them into the web.config. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Preview&lt;/GeneratedBindingRedirectsAction&gt; to create a file containing the proposals. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Overwrite&lt;/GeneratedBindingRedirectsAction&gt; to automatically update web.config with proposals." />
7172

7273
<Warning Condition="'$(GeneratedBindingRedirectsAction)' == 'Preview'"
73-
Text="Generated Binding Redirects have been applied only to the Web.BindingRedirects.config. You should incorporate them into the web.config. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Overwrite&lt;/GeneratedBindingRedirectsAction&gt; to automatically update web.config with proposals." />
74+
File="Web.BindingRedirects.config"
75+
Text="Generated Binding Redirects have been applied only to the Web.BindingRedirects.config. You should incorporate them into the web.config. Consider setting &lt;GeneratedBindingRedirectsAction&gt;Overwrite&lt;/GeneratedBindingRedirectsAction&gt; to automatically update web.config with proposals." />
7476

7577
<Warning Condition="'$(GeneratedBindingRedirectsAction)' == 'Overwrite'"
76-
Text="Generated Binding Redirects have been applied automatically to the web.config. This warning will disappear on the next build." />
78+
File="Web.config"
79+
Text="Generated Binding Redirects have been applied automatically to the Web.config. This warning will disappear on the next build." />
7780

7881
</Target>
79-
80-
81-
8282
</Project>

0 commit comments

Comments
 (0)