there are no condition references in the result

Author: emilefokkemanavara

test/engine-event.test.js

@@ -20,6 +20,10 @@ describe('Engine: event', () => {
       canOrderDrinks: true
     }
   }
+
+  const awesomeEvent = {
+    type: 'awesome'
+  }
   /**
    * sets up a simple 'any' rule with 2 conditions
    */
@@ -92,6 +96,26 @@ describe('Engine: event', () => {
     engine.addFact('gender', 'male') // gender succeeds
   }
 
+  function setupWithConditionReference () {
+    const conditionName = 'awesomeCondition'
+    const conditions = {
+      any: [{ condition: conditionName }]
+    }
+    engine = engineFactory()
+    const ruleOptions = { conditions, event: awesomeEvent, priority: 100 }
+    const rule = factories.rule(ruleOptions)
+    engine.addRule(rule)
+    engine.setCondition(conditionName, {
+      all: [{
+        name: 'over 21',
+        fact: 'age',
+        operator: 'greaterThanInclusive',
+        value: 21
+      }]
+    })
+    engine.addFact('age', 21)
+  }
+
   context('engine events: simple', () => {
     beforeEach(() => simpleSetup())
 
@@ -602,4 +626,13 @@ describe('Engine: event', () => {
       expect(JSON.stringify(ruleResult)).to.equal(expected)
     })
   })
+
+  context('rule events: json serializing with condition reference', () => {
+    beforeEach(() => setupWithConditionReference())
+    it('serializes properties', async () => {
+      const { results: [ruleResult] } = await engine.run()
+      const expected = '{"conditions":{"priority":1,"any":[{"priority":1,"all":[{"name":"over 21","operator":"greaterThanInclusive","value":21,"fact":"age","factResult":21,"result":true}]}]},"event":{"type":"awesome"},"priority":100,"result":true}'
+      expect(JSON.stringify(ruleResult)).to.equal(expected)
+    })
+  })
 })

types/index.d.ts

@@ -229,7 +229,6 @@ type ConditionReference = {
   name?: string;
   priority?: number;
 };
-type ConditionReferenceResult = ConditionReference & ConditionResultProperties;
 export type TopLevelCondition =
   | AllConditions
   | AnyConditions
@@ -239,4 +238,3 @@ export type TopLevelConditionResult =
   | AllConditionsResult
   | AnyConditionsResult
   | NotConditionsResult
-  | ConditionReferenceResult