-
Notifications
You must be signed in to change notification settings - Fork 503
Description
Summary
Version 7.x of json-rules-engine represents a major version bump from 6.x, but there is no official changelog documenting the changes. This makes it difficult for users to safely upgrade and understand what breaking changes they need to account for.
The CHANGELOG.md file in the package only goes up to version 6.1.0, leaving versions 6.2.0 through 7.3.1 completely undocumented.
Impact
- Users are hesitant to upgrade due to unknown breaking changes
- Security vulnerability in
jsonpath-plus(CVE-2024-21534) requires upgrading to v7+ - Issue version 7 - DesignΒ #372 discusses v7 design but doesn't provide a migration guide
- Existing issue about "list of breaking changes v7" shows community need for this information
Unofficial Community Changelog (6.5.0 β 7.3.1)
π΄ BREAKING CHANGES
1. Node.js Version Requirement
- v6.5.0: No engine requirement
+ v7.x: Requires Node.js >= 18.0.02. Security: jsonpath-plus Dependency Updated
- v6.5.0: jsonpath-plus@^7.2.0 (vulnerable to RCE - CVE-2024-21534)
+ v7.x: jsonpath-plus@^10.3.0 (patched)This is the primary reason to upgrade to v7.
3. Removed Dependency
- v6.5.0: lodash.isobjectlike@^4.0.0
+ v7.x: Removed (replaced with internal implementation)Impact: Internal change only, should not affect user code
4. API Change: addOperator() Return Type
// v6.5.0
engine.addOperator(operator): Map<string, Operator>
// v7.x
engine.addOperator(operator): voidImpact: Code that uses the return value of addOperator() will break.
Example of breaking code:
// This will break in v7
const operators = engine.addOperator('customOp', callback);
operators.get('customOp'); // β operators is now void
// Instead, operators should be tracked separately
engine.addOperator('customOp', callback); // β
Returns void in v75. Deprecation: rule.ruleEvent Property
// v6.5.0
rule.event // β
Available
// v7.x
rule.ruleEvent // β οΈ Deprecated (still works but shows warning)
rule.event // β
PreferredImpact: Soft breaking change - existing code using rule.event continues to work
6. Event Handler Type Signature
// v6.5.0
engine.on('success', handler: EventHandler): this
engine.on('failure', handler: EventHandler): this
// v7.x
engine.on<T = Event>(eventName: string, handler: EventHandler<T>): thisImpact: More flexible, backwards compatible for JavaScript users. TypeScript users get better type inference.
β¨ NEW FEATURES
7. Operator Decorators (Major new feature)
New APIs:
engine.addOperatorDecorator(decorator: OperatorDecorator): void
engine.addOperatorDecorator<A, B, NextA, NextB>(
decoratorName: string,
callback: OperatorDecoratorEvaluator<A, B, NextA, NextB>
): void
engine.removeOperatorDecorator(decorator: OperatorDecorator | string): boolean
// New class
class OperatorDecorator {
constructor(
name: string,
evaluator: OperatorDecoratorEvaluator<A, B, NextA, NextB>,
validator?: (factValue: A) => boolean
)
}Allows wrapping operators with additional logic for preprocessing, logging, or custom validation.
New distribution files added:
dist/operator-decorator.jsdist/operator-map.jsdist/engine-default-operator-decorators.js
8. Enhanced Result Types
New TypeScript types for better result handling:
TopLevelConditionResultRuleResultSerializableConditionResultPropertiesBooleanConditionResultProperties- Various condition result types (
AllConditionsResult,AnyConditionsResult,NotConditionsResult,ConditionReferenceResult)
Enhanced RuleResult interface:
interface RuleResult {
toJSON(): string;
toJSON<T extends boolean>(stringify: T): T extends true ? string : RuleResultSerializable;
}π MIGRATION CHECKLIST
When upgrading from v6.x to v7.x:
- β Verify Node.js version is >= 18.0.0
- π Search codebase for
addOperator()usage and remove any code that depends on its return value - π (Optional) Search for
rule.ruleEventand replace withrule.event β οΈ IMPORTANT: Update Jest/Vitest configs that mapjsonpath-plusto use v10.3.0 CommonJS build (see jsonpath-plus expects browser to use ESMΒ #417)- π§ͺ Run full test suite
- π¬ Test in a staging environment before production deployment
Search commands:
# Find addOperator usage
grep -r "addOperator" --include="*.ts" --include="*.js"
# Find deprecated ruleEvent usage
grep -r "\.ruleEvent" --include="*.ts" --include="*.js"β οΈ KNOWN ISSUE: ESM/CommonJS Compatibility (#417)
As reported in Issue #417, [email protected] serves ESM modules for browsers, but json-rules-engine v7.3.1 only supports CommonJS. This causes issues in browser environments and test runners like Jest/Vitest.
Workaround for Jest/Vitest:
// jest.config.js or vitest.config.js
moduleNameMapper: {
"^jsonpath-plus$":
"<rootDir>/node_modules/.pnpm/[email protected]/node_modules/jsonpath-plus/dist/index-node-cjs.cjs"
}Impact: If you're running json-rules-engine in browser tests, you'll need to configure your test runner to use the CommonJS build of jsonpath-plus.
Request to Maintainers
Could the maintainers please:
- Update the CHANGELOG.md with official release notes for versions 6.2.0 through 7.3.1
- Document any breaking changes that were introduced
- Provide a migration guide from v6 to v7
- Consider publishing release notes for future versions on the GitHub Releases page
Having an official changelog is crucial for:
- Understanding breaking changes before upgrading
- Planning migration efforts
- Maintaining trust in semantic versioning
- Helping users upgrade safely to get the security fix for
jsonpath-plus
The security vulnerability in jsonpath-plus makes upgrading to v7 important, but the lack of documentation makes users hesitant to do so.
How This Changelog Was Created
This unofficial changelog was created by:
- Comparing TypeScript definitions (
types/index.d.ts) between v6.5.0 and v7.3.1 - Analyzing
package.jsondifferences (dependencies, engines) - Comparing distribution files (
dist/directory) - Reviewing Issue #372 for v7 design goals
- Testing the changes in a real project
Community Contributions Welcome
If others have found additional breaking changes or differences not listed here, please comment below so we can build a more complete picture of what changed in v7.
Related Issues
- version 7 - DesignΒ #372 - version 7 - Design
- list of breaking changes v7Β #408 - list of breaking changes v7 (community request for changelog)
- jsonpath-plus expects browser to use ESMΒ #417 - jsonpath-plus expects browser to use ESM (ESM/CommonJS compatibility issue)
- fix(deps): update dependency jsonpath-plus to 10.0.0 due to vulnerabilityΒ #379 - PR: fix(deps): update dependency jsonpath-plus to 10.0.0 due to vulnerability
References
Community Members: Please add your findings in the comments if you discover additional changes during your upgrade process.
Maintainers: Thank you for this excellent library! An official changelog would be greatly appreciated by the community. π