🧹 pages: refactor model find algo

Author: vnepogodin

src/pages/dns.rs

@@ -63,19 +63,11 @@ fn create_connections_section() -> gtk::Box {
     // preset the current active connection
     if let Some(active_conn_name) = actions::get_active_connection_name() {
         let model = combo_conn.model().unwrap();
-        if let Some(iter) = model.iter_first() {
-            loop {
-                if model.value(&iter, 0).get::<String>().unwrap() == active_conn_name {
-                    combo_conn.set_active_iter(Some(&iter));
-
-                    let selected_dns_index = selection_index_for_connection(&active_conn_name);
-                    combo_servers.set_active(Some(selected_dns_index as u32));
-                    break;
-                }
-                if !model.iter_next(&iter) {
-                    break;
-                }
-            }
+        if let Some(iter) = utils::find_iter_in_model(model, active_conn_name) {
+            combo_conn.set_active_iter(Some(&iter));
+
+            let selected_dns_index = selection_index_for_connection(&active_conn_name);
+            combo_servers.set_active(Some(selected_dns_index as u32));
         }
     }
 

src/utils.rs

@@ -70,6 +70,27 @@ pub fn check_regular_file(path: &str) -> bool {
     }
 }
 
+pub fn find_iter_in_model(
+    model: &impl IsA<gtk::TreeModel>,
+    search_text: &str,
+) -> Option<gtk::TreeIter> {
+    if let Some(iter) = model.iter_first() {
+        loop {
+            if let Ok(value) = model.value(&iter, 0).get::<String>() {
+                if value == search_text {
+                    return Some(iter);
+                }
+            }
+
+            if !model.iter_next(&iter) {
+                break;
+            }
+        }
+    }
+
+    None
+}
+
 pub fn create_combo_with_model(group_store: &gtk::ListStore) -> gtk::ComboBox {
     let group_combo = gtk::ComboBox::with_model(group_store);
     let combo_renderer = gtk::CellRendererText::new();