👷 pages: refactor exe path check

use `which` crate instead of unix `which` executable

Author: vnepogodin

Cargo.lock

@@ -28,6 +28,7 @@ chwd = { git = "https://github.com/CachyOS/chwd", rev = "3b288ba0d86b1d078057eb7
 tracing = "0.1"
 tracing-subscriber = { version = "0.3", features = ["env-filter"] }
 tracing-appender = "0.2"
+which = { version = "7.0", features = ["tracing"] }
 
 [build-dependencies]
 anyhow = "1"

Cargo.toml

@@ -10,7 +10,7 @@ pub fn setup_logger() -> WorkerGuard {
 
     // create subscriber env filter
     let subscriber_env_filter =
-        env_filter.unwrap_or_else(|_| EnvFilter::new("debug,i18n_embed=warn"));
+        env_filter.unwrap_or_else(|_| EnvFilter::new("debug,i18n_embed=warn,which=warn"));
 
     // create stdout layer
     let stdout_log = tracing_subscriber::fmt::layer().compact().with_writer(std::io::stdout);

src/logger.rs

@@ -17,6 +17,7 @@ use once_cell::sync::Lazy;
 use phf::phf_ordered_map;
 use subprocess::{Exec, Redirection};
 use tracing::debug;
+use which::which;
 
 #[macro_export]
 macro_rules! create_gtk_button {
@@ -1071,17 +1072,14 @@ fn on_appbtn_clicked(button: &gtk::Button) {
         ""
     };
 
-    // Check if executable exists.
-    let exit_status = Exec::cmd("which").arg(binname).join().unwrap();
-    if !exit_status.success() {
+    // Get executable path, overwise return if it doesn't exist.
+    let exec_path = which(binname);
+    if exec_path.is_err() {
         return;
     }
 
     // Get executable path.
-    let mut exe_path =
-        Exec::cmd("which").arg(binname).stdout(Redirection::Pipe).capture().unwrap().stdout_str();
-    exe_path.pop();
-    let bash_cmd = format!("{} &disown", &exe_path);
+    let bash_cmd = format!("{} &disown", exec_path.unwrap().to_str().unwrap());
 
     // Create context channel.
     let (tx, rx) = glib::MainContext::channel(glib::Priority::default());