Skip to content

Commit e3b5a5d

Browse files
docs: add sync warning to integration test helpers
The test helpers replicate production logic from api_aggregate.php because the production functions require DB/session state. Add a comment documenting this dependency and the lines that must stay in sync. Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
1 parent 5cf0e86 commit e3b5a5d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tests/Unit/AggregatePtileFormatIntegrationTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,12 @@
2525
* for 95th percentile, roughly doubling the displayed value.
2626
*
2727
* See: https://github.com/Cacti/cacti/issues/6835
28+
*
29+
* SYNC WARNING: process_ptile_pparts() and process_text_format() below
30+
* replicate logic from lib/api_aggregate.php (lines ~412-427, ~1430-1439,
31+
* ~1512-1521). Production functions require DB/session state that prevents
32+
* direct invocation in unit tests. If the production replacement logic
33+
* changes, these helpers must be updated to match.
2834
*/
2935

3036
require_once dirname(__DIR__) . '/Helpers/CactiStubs.php';

0 commit comments

Comments
 (0)