Refactor - Migrats JS functions to functions.js #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheWitness
approved these changes
Jan 2, 2026
TheWitness
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the JavaScript functionality for the Audit plugin by moving inline scripts from
audit.phpinto a new, dedicated filejs/functions.js. This change improves code organization, maintainability, and reusability. No functional changes were made; the logic was simply relocated and slightly refactored for clarity.JavaScript refactoring and organization:
audit.phpand placed it into a new file,js/functions.js, with improved function naming and comments for clarity. ([[1]](https://github.com/Cacti/plugin_audit/pull/43/files#diff-f08519ce6864967c56cf3b1a348441c4784a8e5b226c0710e17940fc38ff3cccL341-L388),[[2]](https://github.com/Cacti/plugin_audit/pull/43/files#diff-f08519ce6864967c56cf3b1a348441c4784a8e5b226c0710e17940fc38ff3cccL511-R463),[[3]](https://github.com/Cacti/plugin_audit/pull/43/files#diff-31238393ef9ee4284c3da472dd0c96c5ec04cd250e7626f57a0e96bcb262df3cR1-R150))audit.phpto include the newjs/functions.jsscript instead of inline JavaScript. ([audit.phpL511-R463](https://github.com/Cacti/plugin_audit/pull/43/files#diff-f08519ce6864967c56cf3b1a348441c4784a8e5b226c0710e17940fc38ff3cccL511-R463))No changes were made to the PHP business logic or backend functionality.