Fix for issue #65: Extra separator on mac address

netniV · netniV · commit fa08533fa137 · 2018-02-16T01:28:36.000Z
diff --git a/lib/mactrack_functions.php b/lib/mactrack_functions.php
@@ -1811,7 +1811,7 @@ function xform_mac_address($mac_address) {
 		}else{ /* return is hex */
 			$mac = "";
 			for ($j = 0; $j < strlen($mac_address); $j++) {
-				$mac .= bin2hex($mac_address[$j]) . read_config_option("mt_mac_delim");
+				$mac .= bin2hex($mac_address[$j]) . ($j == strlen($mac_address) ? '' : read_config_option("mt_mac_delim"));
 			}
 			$mac_address = $mac;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1811,7 +1811,7 @@ function xform_mac_address($mac_address) {`
`1811`	`1811`	`}else{ /* return is hex */`
`1812`	`1812`	`$mac = "";`
`1813`	`1813`	`for ($j = 0; $j < strlen($mac_address); $j++) {`
`1814`		`- $mac .= bin2hex($mac_address[$j]) . read_config_option("mt_mac_delim");`
	`1814`	`+ $mac .= bin2hex($mac_address[$j]) . ($j == strlen($mac_address) ? '' : read_config_option("mt_mac_delim"));`
`1815`	`1815`	`}`
`1816`	`1816`	`$mac_address = $mac;`
`1817`	`1817`	`}`