Merge pull request #3804 from tpurschke/fix/app-server-comparer-case-insensitive

tpurschke · web-flow · commit 22a809d23290 · 2025-10-21T13:57:58.000+02:00
hotfix: compare appserver name case-insensitive
diff --git a/roles/lib/files/FWO.Services/AppServerComparer.cs b/roles/lib/files/FWO.Services/AppServerComparer.cs
@@ -25,7 +25,7 @@ public bool Equals(ModellingAppServer? appServer1, ModellingAppServer? appServer
 
             string appServer1Name = AppServerHelper.ConstructSanitizedAppServerName(appServer1, NamingConvention);
             string appServer2Name = AppServerHelper.ConstructSanitizedAppServerName(appServer2, NamingConvention);
-            return appServer1Name == appServer2Name;
+            return string.Equals(appServer1Name, appServer2Name, StringComparison.OrdinalIgnoreCase);
         }
 
         public int GetHashCode(ModellingAppServerWrapper appServerWrapper)
@@ -35,7 +35,7 @@ public int GetHashCode(ModellingAppServerWrapper appServerWrapper)
 
         public int GetHashCode(ModellingAppServer appServer)
         {
-            string appServerName = AppServerHelper.ConstructSanitizedAppServerName(appServer, NamingConvention).Trim();
+            string appServerName = AppServerHelper.ConstructSanitizedAppServerName(appServer, NamingConvention).ToLower().Trim();
             return HashCode.Combine(appServerName);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public bool Equals(ModellingAppServer? appServer1, ModellingAppServer? appServer`
`25`	`25`
`26`	`26`	`string appServer1Name = AppServerHelper.ConstructSanitizedAppServerName(appServer1, NamingConvention);`
`27`	`27`	`string appServer2Name = AppServerHelper.ConstructSanitizedAppServerName(appServer2, NamingConvention);`
`28`		`- return appServer1Name == appServer2Name;`
	`28`	`+ return string.Equals(appServer1Name, appServer2Name, StringComparison.OrdinalIgnoreCase);`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`public int GetHashCode(ModellingAppServerWrapper appServerWrapper)`
`@@ -35,7 +35,7 @@ public int GetHashCode(ModellingAppServerWrapper appServerWrapper)`
`35`	`35`
`36`	`36`	`public int GetHashCode(ModellingAppServer appServer)`
`37`	`37`	`{`
`38`		`- string appServerName = AppServerHelper.ConstructSanitizedAppServerName(appServer, NamingConvention).Trim();`
	`38`	`+ string appServerName = AppServerHelper.ConstructSanitizedAppServerName(appServer, NamingConvention).ToLower().Trim();`
`39`	`39`	`return HashCode.Combine(appServerName);`
`40`	`40`	`}`
`41`	`41`	`}`