Merge pull request #3912 from tpurschke/fix/develop/new-docker-syntax

develop - fix play for docker start (no ports and no pull)

Author: tpurschke

roles/api/tasks/hasura-install.yml

@@ -2,209 +2,205 @@
 
 - name: Install packages for python pip3 n virtualenv
   package:
-    name: "{{ item }}"
-    state: present
+      name: "{{ item }}"
+      state: present
   loop:
-    - python3-pip
-    - python3-virtualenv
-    - python3-docker
+      - python3-pip
+      - python3-virtualenv
+      - python3-docker
   become: true
 
 - name: read dbadmin pwd from secrets file
   slurp:
-    src: "{{ dbadmin_password_file }}"
+      src: "{{ dbadmin_password_file }}"
   register: api_user_password
   become: true
 
 - name: decode dbadmin pwd
   set_fact:
-    api_user_password: "{{ api_user_password['content'] | b64decode | trim }}"
+      api_user_password: "{{ api_user_password['content'] | b64decode | trim }}"
 
 - name: read jwt public key from file as JWT secret
   slurp:
-    src: "{{ jwt_public_key_file }}"
+      src: "{{ jwt_public_key_file }}"
   register: api_hasura_jwt_secret_dict
   become: true
 
 - name: decode key
   set_fact:
-    api_hasura_jwt_secret: "{{ api_hasura_jwt_secret_dict['content'] | b64decode }}"
+      api_hasura_jwt_secret: "{{ api_hasura_jwt_secret_dict['content'] | b64decode }}"
 
 - name: make sure {{ fworch_secrets_dir }} exists
   file:
-    path: "{{ fworch_secrets_dir }}"
-    state: directory
-    mode: "0750"
-    owner: "{{ fworch_user }}"
-    group: "{{ postgres_group }}"
+      path: "{{ fworch_secrets_dir }}"
+      state: directory
+      mode: "0750"
+      owner: "{{ fworch_user }}"
+      group: "{{ postgres_group }}"
   become: true
 
 - name: set static hasura admin pwd for test purposes only
   set_fact:
-    api_hasura_admin_secret: "{{ api_hasura_admin_test_password }}"
+      api_hasura_admin_secret: "{{ api_hasura_admin_test_password }}"
   when: testkeys is defined and testkeys|bool
 
 - name: set random hasura admin password
   set_fact:
-    api_hasura_admin_secret: "{{ randomly_generated_pwd }}"
+      api_hasura_admin_secret: "{{ randomly_generated_pwd }}"
   when: testkeys is not defined or not testkeys|bool
 
 - name: write hasura admin password to secrets directory
   copy:
-    content: "{{ api_hasura_admin_secret }}\n"
-    dest: "{{ fworch_secrets_dir }}/hasura_admin_pwd"
-    mode: '0600'
-    owner: "{{ fworch_user }}"
-    group: "{{ fworch_group }}"
+      content: "{{ api_hasura_admin_secret }}\n"
+      dest: "{{ fworch_secrets_dir }}/hasura_admin_pwd"
+      mode: "0600"
+      owner: "{{ fworch_user }}"
+      group: "{{ fworch_group }}"
   become: true
 
 - name: check for existing hasura cli file
   stat:
-    path: "{{ api_hasura_cli_bin }}"
+      path: "{{ api_hasura_cli_bin }}"
   register: api_cli_check
 
 # only download new version of api cli, when not restoring from backup:
 - name: download {{ api_hasura_version }} hasura cli binary
   get_url:
-    url: "https://github.com/hasura/graphql-engine/releases/download/{{ api_hasura_version }}/cli-hasura-linux-amd64"
-    dest: "{{ api_hasura_cli_bin }}"
-    force: true
-    mode: "0755"
-    owner: "{{ fworch_user }}"
-    group: "{{ fworch_group }}"
+      url: "https://github.com/hasura/graphql-engine/releases/download/{{ api_hasura_version }}/cli-hasura-linux-amd64"
+      dest: "{{ api_hasura_cli_bin }}"
+      force: true
+      mode: "0755"
+      owner: "{{ fworch_user }}"
+      group: "{{ fworch_group }}"
   environment: "{{ proxy_env }}"
   become: true
-  when: not api_cli_check.stat.exists 
+  when: not api_cli_check.stat.exists
 
 - name: initialize hasura cli directory
   command: "{{ api_hasura_cli_bin }} init {{ product_name }} --skip-update-check --endpoint http://{{ api_local_listening_ip_address }}:{{ api_port }} --admin-secret {{ api_hasura_admin_secret }}"
-  args: 
-    chdir: "{{ api_home }}"
+  args:
+      chdir: "{{ api_home }}"
   become: true
   become_user: "{{ fworch_user }}"
   environment: "{{ proxy_env }}"
   when: not api_cli_check.stat.exists
 
 - name: set hasura env variable
   set_fact:
-    hasura_env:
-      HASURA_GRAPHQL_DATABASE_URL:     "postgres://{{ api_user }}:{{ api_user_password }}@{{ fworch_db_host }}:{{ fworch_db_port }}/{{ fworch_db_name }}"
-      HASURA_GRAPHQL_ENABLE_CONSOLE:   "true"
-      HASURA_GRAPHQL_ENABLE_TELEMETRY: "false"
-      HASURA_GRAPHQL_ADMIN_SECRET:     "{{ api_hasura_admin_secret }}"
-      HASURA_GRAPHQL_SERVER_HOST:       "127.0.0.1"
-      HASURA_GRAPHQL_SERVER_PORT:       "8080"
-      HASURA_GRAPHQL_LOG_LEVEL:        "{{ api_log_level }}"
-      HASURA_GRAPHQL_ENABLED_LOG_TYPES: '{{ api_HASURA_GRAPHQL_ENABLED_LOG_TYPES }}'
-      HASURA_GRAPHQL_CONSOLE_ASSETS_DIR: "/srv/console-assets"
-      HASURA_GRAPHQL_V1_BOOLEAN_NULL_COLLAPSE: "true"
-      HASURA_GRAPHQL_CORS_DOMAIN:       "*"
-      HASURA_GRAPHQL_INFER_FUNCTION_PERMISSIONS: "{{ api_HASURA_GRAPHQL_INFER_FUNCTION_PERMISSIONS }}"
-      HASURA_GRAPHQL_JWT_SECRET:        '
-                                        {
-                                          "type": "{{ api_hasura_jwt_alg|quote }}",
-                                          "key": "{{ api_hasura_jwt_secret | regex_replace(''\n'', ''\\n'') }}",
-                                          "claims_namespace_path": "$"
-                                        }
-                                        '
-      HTTP_PROXY:                      "{{ http_proxy }}"
-      HTTPS_PROXY:                     "{{ https_proxy }}"
-      http_proxy:                      "{{ http_proxy }}"
-      https_proxy:                     "{{ https_proxy }}"
-      no_proxy:                        "{{ no_proxy }}"
-      NO_PROXY:                        "{{ no_proxy }}"
+      hasura_env:
+          HASURA_GRAPHQL_DATABASE_URL: "postgres://{{ api_user }}:{{ api_user_password }}@{{ fworch_db_host }}:{{ fworch_db_port }}/{{ fworch_db_name }}"
+          HASURA_GRAPHQL_ENABLE_CONSOLE: "true"
+          HASURA_GRAPHQL_ENABLE_TELEMETRY: "false"
+          HASURA_GRAPHQL_ADMIN_SECRET: "{{ api_hasura_admin_secret }}"
+          HASURA_GRAPHQL_SERVER_HOST: "127.0.0.1"
+          HASURA_GRAPHQL_SERVER_PORT: "8080"
+          HASURA_GRAPHQL_LOG_LEVEL: "{{ api_log_level }}"
+          HASURA_GRAPHQL_ENABLED_LOG_TYPES: "{{ api_HASURA_GRAPHQL_ENABLED_LOG_TYPES }}"
+          HASURA_GRAPHQL_CONSOLE_ASSETS_DIR: "/srv/console-assets"
+          HASURA_GRAPHQL_V1_BOOLEAN_NULL_COLLAPSE: "true"
+          HASURA_GRAPHQL_CORS_DOMAIN: "*"
+          HASURA_GRAPHQL_INFER_FUNCTION_PERMISSIONS: "{{ api_HASURA_GRAPHQL_INFER_FUNCTION_PERMISSIONS }}"
+          HASURA_GRAPHQL_JWT_SECRET: '
+              {
+              "type": "{{ api_hasura_jwt_alg|quote }}",
+              "key": "{{ api_hasura_jwt_secret | regex_replace(''\n'', ''\\n'') }}",
+              "claims_namespace_path": "$"
+              }
+              '
+          HTTP_PROXY: "{{ http_proxy }}"
+          HTTPS_PROXY: "{{ https_proxy }}"
+          http_proxy: "{{ http_proxy }}"
+          https_proxy: "{{ https_proxy }}"
+          no_proxy: "{{ no_proxy }}"
+          NO_PROXY: "{{ no_proxy }}"
 
 - name: show hasura env for debugging
   debug:
-    var:
-      hasura_env
+      var: hasura_env
   when: debug_level > '1'
 
 - name: start hasura container
   docker_container:
-    name: "{{ api_container_name }}"
-    image: hasura/graphql-engine:{{ api_hasura_version }}
-    state: started
-    network_mode: host
-    networks_cli_compatible: true
-    log_driver: syslog
-    log_options:
-      syslog-address: "{{ syslog_proto }}://{{ syslog_host }}:{{ syslog_port }}"
-      syslog-facility: daemon
-      tag: "{{ api_container_name }}"
-    recreate: true
-    exposed_ports:
-      - "{{ api_port }}:{{ api_port }}"
-    env:
-      "{{ hasura_env }}"
-    container_default_behavior: no_defaults
-    user: "1001:1001"  # hasura user and group id
+      name: "{{ api_container_name }}"
+      image: hasura/graphql-engine:{{ api_hasura_version }}
+      state: started
+      network_mode: host
+      networks_cli_compatible: true
+      log_driver: syslog
+      log_options:
+          syslog-address: "{{ syslog_proto }}://{{ syslog_host }}:{{ syslog_port }}"
+          syslog-facility: daemon
+          tag: "{{ api_container_name }}"
+      recreate: true
+      env: "{{ hasura_env }}"
+      container_default_behavior: no_defaults
+      user: "1001:1001" # hasura user and group id
+      pull: no
   register: docker_return
   become: true
   become_user: "{{ fworch_user }}"
   environment: "{{ proxy_env }}"
 
 - name: show docker result
   debug:
-    var:
-      docker_return
+      var: docker_return
   when: debug_level > '1'
 
 - name: Get info on container
   docker_container_info:
-    name: "{{ api_container_name }}"
+      name: "{{ api_container_name }}"
   register: result
   become: true
   become_user: "{{ fworch_user }}"
 
 - name: Print the status of the container in case of problems only
-  fail: 
-    msg: "The container status is: {{ result }}"
+  fail:
+      msg: "The container status is: {{ result }}"
   when: result.exists and result.container['State']['Status'] == 'exited'
 
 - name: copy hasura systemd service script
   template:
-     src: "{{ api_service_name }}.service.j2"
-     dest: "/lib/systemd/system/{{ api_service_name }}.service"
-     backup: true
-     mode: "0644"
-     owner: "root"
+      src: "{{ api_service_name }}.service.j2"
+      dest: "/lib/systemd/system/{{ api_service_name }}.service"
+      backup: true
+      mode: "0644"
+      owner: "root"
   become: true
 
 - name: make hasura docker container run at host startup
   systemd:
-    name: "{{ api_service_name }}"
-    daemon_reload: true
-    enabled: true
+      name: "{{ api_service_name }}"
+      daemon_reload: true
+      enabled: true
   become: true
 
-- name:  wait for hasura port to become available
+- name: wait for hasura port to become available
   wait_for:
-    port: "{{ api_port }}"
-    host: "{{ api_local_listening_ip_address }}"
-    connect_timeout: 1
-    delay: 10
-    timeout: 25
+      port: "{{ api_port }}"
+      host: "{{ api_local_listening_ip_address }}"
+      connect_timeout: 1
+      delay: 10
+      timeout: 25
 
 - name: check for existing api dir from restore
   stat:
-    path: "{{ api_home }}/{{ product_name }}"
+      path: "{{ api_home }}/{{ product_name }}"
   register: api_metadata_check
 
 - name: import API metadata via metadata API directly from local file
-  uri: 
-    url: "http://{{ api_local_listening_ip_address }}:{{ api_port }}/v1/metadata"
-    method: POST
-    return_content: true
-    body_format: json    
-    headers:
-      Content-Type: application/json      
-      x-hasura-admin-secret: "{{ api_hasura_admin_secret }}"
-      x-hasura-role: "admin"
-    body: "{{ lookup('file','replace_metadata.json') | from_json }}"
+  uri:
+      url: "http://{{ api_local_listening_ip_address }}:{{ api_port }}/v1/metadata"
+      method: POST
+      return_content: true
+      body_format: json
+      headers:
+          Content-Type: application/json
+          x-hasura-admin-secret: "{{ api_hasura_admin_secret }}"
+          x-hasura-role: "admin"
+      body: "{{ lookup('file','replace_metadata.json') | from_json }}"
   when: not api_rollback_is_running | bool
   # do not install latest metadata in case of rollback
   environment:
-    http_proxy: ""
-    https_proxy: ""
-  # do not use http proxy for metadata import 
+      http_proxy: ""
+      https_proxy: ""
+  # do not use http proxy for metadata import