Skip to content

Commit c227964

Browse files
authored
Merge branch 'importer-rework' into feature/3782-crosstablesRulesZone
2 parents f12b6c4 + f99bed8 commit c227964

File tree

4 files changed

+138
-116
lines changed

4 files changed

+138
-116
lines changed

roles/lib/files/FWO.Report/ReportDevicesBase.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ public string DisplayReportHeaderJson()
202202
{
203203
report.AppendLine($"\"date of configuration shown\": \"{DateTime.Parse(Query.ReportTimeString).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ssK")} (UTC)\",");
204204
}
205-
report.AppendLine($"# device filter: {string.Join(" ", ReportData.ManagementData.Where(mgt => !mgt.Ignore).Cast<ManagementReportController>().Select(m => m.NameAndRulebaseNames(" ")))}");
205+
report.AppendLine($"# device filter: {string.Join(" ", ReportData.ManagementData.Where(mgt => !mgt.Ignore).Select(mgm => new ManagementReportController(mgm)).Select(m => m.NameAndRulebaseNames(" ")))}");
206206
report.AppendLine($"\"other filters\": \"{Query.RawFilter}\",");
207207
report.AppendLine($"\"report generator\": \"Firewall Orchestrator - https://fwo.cactus.de/en\",");
208208
report.AppendLine($"\"data protection level\": \"For internal use only\",");
@@ -218,7 +218,7 @@ public string DisplayReportHeaderCsv()
218218
{
219219
report.AppendLine($"# date of configuration shown: {DateTime.Parse(Query.ReportTimeString).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ssK")} (UTC)");
220220
}
221-
report.AppendLine($"# device filter: {string.Join(" ", ReportData.ManagementData.Where(mgt => !mgt.Ignore).Cast<ManagementReportController>().Select(m => m.NameAndRulebaseNames(" ")))}");
221+
report.AppendLine($"# device filter: {string.Join(" ", ReportData.ManagementData.Where(mgt => !mgt.Ignore).Select(mgm => new ManagementReportController(mgm)).Select(m => m.NameAndRulebaseNames(" ")))}");
222222
report.AppendLine($"# other filters: {Query.RawFilter}");
223223
report.AppendLine($"# report generator: Firewall Orchestrator - https://fwo.cactus.de/en");
224224
report.AppendLine($"# data protection level: For internal use only");

roles/lib/files/FWO.Report/ReportRules.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public override async Task Generate(int elementsPerFetch, ApiConnection apiConne
8181
TryBuildRuleTree();
8282
}
8383

84-
private void TryBuildRuleTree()
84+
protected void TryBuildRuleTree()
8585
{
8686
int ruleCount = 0;
8787

0 commit comments

Comments
 (0)