Skip to content

Conversation

@abarz722
Copy link
Contributor

@abarz722 abarz722 commented Nov 5, 2025

No description provided.

@sonarqubecloud
Copy link

@abarz722 abarz722 marked this pull request as ready for review November 16, 2025 08:33
@abarz722 abarz722 requested a review from tpurschke November 16, 2025 08:34
Copy link
Contributor

@tpurschke tpurschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to decide if we merge #3885 first or if we merge this one first and after #3885 (re-)add rule_metadata.mgm_id afterwards again in multiple places.
@abarz722 , @Imat00 what do you think? I tend to lean towards #3885 before #3882

SELECT INTO t_rule_created rule_metadata.rule_created
FROM rule
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid AND rule.dev_id=rule_metadata.dev_id)
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

delete_recertification(
where: {
owner_id: { _eq: $ownerId }
rule_metadatum: { device: { mgm_id: { _eq: $mgmId } } }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

FROM view_rule_with_owner
LEFT JOIN rule USING (rule_id)
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid AND rule.dev_id=rule_metadata.dev_id)
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

FROM view_rule_with_owner
LEFT JOIN rule USING (rule_id)
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid AND rule.dev_id=rule_metadata.dev_id)
LEFT JOIN rule_metadata ON (rule.rule_uid=rule_metadata.rule_uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

view_rule_with_owner V
LEFT JOIN rule R USING (rule_id)
LEFT JOIN rule_metadata M ON (R.rule_uid=M.rule_uid AND R.dev_id=M.dev_id)
LEFT JOIN rule_metadata M ON (R.rule_uid=M.rule_uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

view_rule_with_owner V
LEFT JOIN rule R USING (rule_id)
LEFT JOIN rule_metadata M ON (R.rule_uid=M.rule_uid AND R.dev_id=M.dev_id)
LEFT JOIN rule_metadata M ON (R.rule_uid=M.rule_uid)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).


[JsonProperty("dev_id"), JsonPropertyName("dev_id")]
public int DeviceId { get; set; }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to add mgm_id here (when #3885 is merged).

@Imat00
Copy link
Contributor

Imat00 commented Nov 17, 2025

need to decide if we merge #3885 first or if we merge this one first and after #3885 (re-)add rule_metadata.mgm_id afterwards again in multiple places. @abarz722 , @Imat00 what do you think? I tend to lean towards #3885 before #3882

I would also say we should merge #3885 first, since #3882 seems to depend on those changes.

@Elutrixx
Copy link
Contributor

Throwing my 2 cents into the ring: I am kinda dependant on parts of #3882 being merged in so whichever way merges that in sooner rather than later would be awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants