Set sys.last_traceback on errors (#255)

* Set last traceback

* correctly handle SyntaxError

* Check if last_traceback is set

* Adjust prios

* Set exception info in debug too

* Check both run and debug

* Fixed tests

Author: adam-urbanczyk

cq_editor/widgets/debugger.py

@@ -246,8 +246,9 @@ def render(self):
                                    cq_script)
             self.sigLocals.emit(module.__dict__)
         except Exception:
-            self.sigTraceback.emit(sys.exc_info(),
-                                   cq_script)
+            exc_info = sys.exc_info()
+            sys.last_traceback = exc_info[-1]
+            self.sigTraceback.emit(exc_info, cq_script)
 
     @property
     def breakpoints(self):
@@ -280,7 +281,9 @@ def debug(self,value):
                 sys.settrace(self.trace_callback)
                 exec(code,module.__dict__,module.__dict__)
             except Exception:
-                self.sigTraceback.emit(sys.exc_info(),
+                exc_info = sys.exc_info()
+                sys.last_traceback = exc_info[-1]
+                self.sigTraceback.emit(exc_info,
                                        self.script)
             finally:
                 sys.settrace(previous_trace)

cq_editor/widgets/traceback_viewer.py

@@ -76,9 +76,11 @@ def addTraceback(self,exc_info,code):
 
             # handle the special case of a SyntaxError
             if t is SyntaxError: 
-                root.addChild(QTreeWidgetItem([exc.filename,
-                                               str(exc.lineno),
-                                               exc.text.strip()]))
+                root.addChild(QTreeWidgetItem(
+                  [exc.filename,
+                   str(exc.lineno),
+                   exc.text.strip() if exc.text else '']
+                ))
         else:
             self.current_exception.setText('')
 
@@ -91,4 +93,4 @@ def handleSelection(self,item,*args):
             if '<string>' in f:
                 self.sigHighlightLine.emit(line)
 
-        
+        

tests/test_app.py

@@ -302,42 +302,40 @@ def test_inspect(main):
     insp._toolbar_actions[0].toggled.emit(False)
     assert(number_visible_items(viewer) == 3)
 
+class event_loop(object):
+    '''Used to mock the QEventLoop for the debugger component
+    '''
 
-def test_debug(main,mocker):
+    def __init__(self,callbacks):
 
-    # store the tracing function
-    trace_function = sys.gettrace()
+        self.callbacks = callbacks
+        self.i = 0
 
-    class event_loop(object):
-        '''Used to mock the QEventLoop for the debugger component
-        '''
+    def exec_(self):
+
+        if self.i<len(self.callbacks):
+            self.callbacks[self.i]()
+            self.i+=1
 
-        def __init__(self,callbacks):
+    def exit(self,*args):
 
-            self.callbacks = callbacks
-            self.i = 0
+        pass
 
-        def exec_(self):
+def patch_debugger(debugger,event_loop_mock):
 
-            if self.i<len(self.callbacks):
-                self.callbacks[self.i]()
-                self.i+=1
+        debugger.inner_event_loop.exec_ = event_loop_mock.exec_
+        debugger.inner_event_loop.exit = event_loop_mock.exit
 
-        def exit(self,*args):
+def test_debug(main,mocker):
 
-            pass
+    # store the tracing function
+    trace_function = sys.gettrace()
 
     def assert_func(x):
         '''Neddedd to perform asserts in lambdas
         '''
         assert(x)
 
-    def patch_debugger(debugger,event_loop_mock):
-
-        debugger.inner_event_loop.exec_ = event_loop_mock.exec_
-        debugger.inner_event_loop.exit = event_loop_mock.exit
-
-
     qtbot, win = main
 
     #clear all
@@ -491,6 +489,20 @@ def test_traceback(main):
     run.triggered.emit()
 
     assert('NameError' in traceback_view.current_exception.text())
+    assert(hasattr(sys, 'last_traceback'))
+    
+    del sys.last_traceback
+    assert(not hasattr(sys, 'last_traceback'))
+    
+    
+    #test last_traceback with debug
+    ev = event_loop([lambda: (cont.triggered.emit(),)])
+    patch_debugger(debugger,ev)
+    
+    debugger.debug(True)
+    
+    assert('NameError' in traceback_view.current_exception.text())
+    assert(hasattr(sys, 'last_traceback'))
 
     # restore the tracing function
     sys.settrace(trace_function)