Return False on Vector comparison with non-Vector (#1610)

* Return NotImplemented on Vector comparison with non-Vector

* Return False on Vector comparison with non-Vector

Author: lorenzncode

cadquery/occ_impl/geom.py

@@ -230,7 +230,11 @@ def __str__(self) -> str:
         return "Vector: " + str((self.x, self.y, self.z))
 
     def __eq__(self, other: "Vector") -> bool:  # type: ignore[override]
-        return self.wrapped.IsEqual(other.wrapped, 0.00001, 0.00001)
+        return (
+            self.wrapped.IsEqual(other.wrapped, 0.00001, 0.00001)
+            if isinstance(other, Vector)
+            else False
+        )
 
     def toPnt(self) -> gp_Pnt:
 

tests/test_cad_objects.py

@@ -805,5 +805,21 @@ def test_wire_makepolygon(points, close, expected_edges):
     assert len(Wire.makePolygon(points, False, close).Edges()) == expected_edges
 
 
+def test_equality():
+
+    # do not raise error comparing with other type
+    assert (Vector(0, 0, 0) == 0) == False
+    assert (Plane.XY() == 0) == False
+
+    list1 = [
+        Vector(0, 0, 0),
+        Plane.XY(),
+        Vertex.makeVertex(0, 0, 0),
+        "a string",
+        4,
+    ]
+    assert [list1.index(item) for item in list1] == [0, 1, 2, 3, 4]
+
+
 if __name__ == "__main__":
     unittest.main()