* Add test for multiple selected edges

* Split params into two variables

Author: lorenzncode

cadquery/sketch.py

@@ -398,31 +398,27 @@ def distribute(
         else:
             trimmed = True
 
-        params = (
-            (start + i * (stop - start) / n for i in range(n)),
-            (
-                start + i * (stop - start) / (n - 1) if n - 1 > 0 else start
-                for i in range(n)
-            ),
-        )
+        # closed edge or wire parameters
+        params_closed = [start + i * (stop - start) / n for i in range(n)]
+
+        # open or trimmed edge or wire parameters
+        params_open = [
+            start + i * (stop - start) / (n - 1) if n - 1 > 0 else start
+            for i in range(n)
+        ]
 
         locs = []
         for el in self._selection:
             if isinstance(el, (Wire, Edge)):
+                if el.IsClosed() and not trimmed:
+                    params = params_closed
+                else:
+                    params = params_open
+
                 if rotate:
-                    locs.extend(
-                        el.locations(
-                            params[0 if el.IsClosed() and not trimmed else 1],
-                            planar=True,
-                        )
-                    )
+                    locs.extend(el.locations(params, planar=True,))
                 else:
-                    locs.extend(
-                        Location(v)
-                        for v in el.positions(
-                            params[0 if el.IsClosed() and not trimmed else 1]
-                        )
-                    )
+                    locs.extend(Location(v) for v in el.positions(params))
             else:
                 raise ValueError(f"Unsupported selection: {el}")
 

tests/test_sketch.py

@@ -154,6 +154,29 @@ def test_distribute():
         (3.358757210636101, -3.005203820042827, 0.0)
     )
 
+    s5 = (
+        Sketch()
+        .arc((0, 2), 4, 0, 90)
+        .arc((0, -2), 4, 0, -90)
+        .edges()
+        .distribute(4, 0, 1)
+        .circle(0.5)
+    )
+
+    assert len(s5._selection) == approx(8)
+
+    s5.reset().faces(">X").faces(">Y")
+
+    assert s5._selection[0].Center().toTuple() == approx((4.0, 2.0, 0.0))
+
+    s5.reset().faces(">X").faces("<Y")
+
+    assert s5._selection[0].Center().toTuple() == approx((4.0, -2.0, 0.0))
+
+    s5.reset().faces(">Y")
+
+    assert s5._selection[0].Center().toTuple() == approx((0.0, 6.0, 0.0))
+
 
 def test_rarray():