Trying to be smarter about using the desired image size

Author: jmwright

cadquery/occ_impl/exporters/svg.py

@@ -240,8 +240,12 @@ def getSVG(shape, opts=None):
     bb_scale = 0.75
     if fitView:
         bb_scale = 1.0
-        width = bb.xlen
-        height = bb.ylen
+
+        # Figure out which dimension to base the adjusted image size on
+        if width / bb.xlen < height / bb.ylen:
+            height = width * (bb.ylen / bb.xlen)
+        else:
+            width = height * (bb.xlen / bb.ylen)
 
     # width pixels for x, height pixels for y
     unitScale = min(width / bb.xlen * bb_scale, height / bb.ylen * bb_scale)

doc/importexport.rst

@@ -216,7 +216,7 @@ options are as follows.
 * *hiddenColor* - Color of the line that hidden edges are drawn with.
 * *showHidden* - Whether or not to show hidden lines.
 * *focus* - If specified, creates a perspective SVG with the projector at the distance specified.
-* *fitView* - If specified, will attempt to fit the height and width of the image to the contents. The ``marginLeft`` and ``marginTop`` options should be set to 0 or the object will fall outside the viewport. The ``width`` and ``height`` options that were specified will be overridden, which can cause unexpected final image sizes.
+* *fitView* - If specified, will attempt to fit the height and width of the image to the contents. The ``marginLeft`` and ``marginTop`` options should be set to 0 or the object will fall outside the viewport. The ``width`` or ``height`` options that were specified will be overridden, but the largest dimension should be preserved.
 
 The options are passed to the exporter in a dictionary, and can be left out to force the SVG to be created with default options. 
 Below are examples with and without options set.