added tests

Author: Jojain

tests/test_cadquery.py

@@ -468,7 +468,7 @@ def testLoft(self):
         self.assertEqual(7, s.faces().size())
 
         # test loft with combine="cut"
-        box = Workplane().box(10, 10, 10).solids()
+        box = Workplane().box(10, 10, 10)
         cut = (
             box.faces(">Z")
             .workplane()
@@ -480,6 +480,19 @@ def testLoft(self):
 
         self.assertGreater(box.val().Volume(), cut.val().Volume())
 
+        # test loft with combine=True
+        box = Workplane().box(10, 10, 10)
+        add = (
+            box.faces(">Z")
+            .workplane()
+            .circle(2)
+            .workplane(offset=12)
+            .rect(3, 2)
+            .loft(combine=True)
+        )
+
+        self.assertGreater(add.val().Volume(),box.val().Volume())
+
     def testLoftRaisesValueError(self):
         s0 = Workplane().hLine(1)  # no wires
         with raises(ValueError):
@@ -1166,6 +1179,17 @@ def testSweep(self):
         )
         self.assertGreater(box.val().Volume(), cut.val().Volume())
 
+        #test sweep with combine = True
+        box = Workplane().box(10, 10, 10, centered=False)
+        path = Workplane("YZ").lineTo(10, 10)
+        add = (
+            box.vertices(">Z and >X and >Y")
+            .workplane(centerOption="CenterOfMass")
+            .circle(1.5)
+            .sweep(path, combine=True)
+        )
+        self.assertGreater(add.val().Volume(),box.val().Volume())
+
     def testMultisectionSweep(self):
         """
         Tests the operation of sweeping along a list of wire(s) along a path