Skip to content

Commit b96eb8a

Browse files
Fix sketch solver line_point method relative/absolute mixup (#1336)
* Sketch: Fix line_point implementation Enable assert that fails without the fix ( issue #1127 ) * Change channel order --------- Co-authored-by: AU <[email protected]>
1 parent 665815b commit b96eb8a

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

cadquery/occ_impl/sketch_solver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def arc_point(x, val):
8484

8585
def line_point(x, val):
8686

87-
return x[:2] + val * x[2:]
87+
return x[:2] + val * (x[2:] - x[:2])
8888

8989

9090
def arc_first_tangent(x):

tests/test_sketch.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ def test_constraint_solver():
640640

641641
midpoint = (seg2.startPoint() + seg2.endPoint()) / 2
642642

643-
(midpoint - seg1.startPoint()).Length == approx(2)
643+
assert (midpoint - seg1.startPoint()).Length == approx(2)
644644

645645
s5 = (
646646
Sketch()

0 commit comments

Comments
 (0)