Fix VTK based assembly export rotation issue (#1078)

Author: lorenzncode

cadquery/assembly.py

@@ -426,8 +426,8 @@ def save(
 
         :param path: filepath
         :param exportType: export format (default: None, results in format being inferred form the path)
-        :param tolerance: the deflection tolerance, in model units. Only used for GLTF. Default 0.1.
-        :param angularTolerance: the angular tolerance, in radians. Only used for GLTF. Default 0.1.
+        :param tolerance: the deflection tolerance, in model units. Only used for GLTF, VRML. Default 0.1.
+        :param angularTolerance: the angular tolerance, in radians. Only used for GLTF, VRML. Default 0.1.
         """
 
         if exportType is None:

cadquery/occ_impl/assembly.py

@@ -1,5 +1,6 @@
 from typing import Iterable, Tuple, Dict, overload, Optional, Any, List
 from typing_extensions import Protocol
+from math import degrees
 
 from OCP.TDocStd import TDocStd_Document
 from OCP.TCollection import TCollection_ExtendedString
@@ -199,7 +200,7 @@ def toVTK(
         actor = vtkActor()
         actor.SetMapper(mapper)
         actor.SetPosition(*trans)
-        actor.SetOrientation(*rot)
+        actor.SetOrientation(*map(degrees, rot))
         actor.GetProperty().SetColor(*color[:3])
         actor.GetProperty().SetOpacity(color[3])
 

cadquery/utils.py

@@ -63,7 +63,7 @@ def wrapped(*args, **kwargs):
 
             if f_sig_params[self.name]:
                 warn(
-                    f"Kwarg <{self.name}> will be removed. Plase use <{self.new_name}>",
+                    f"Kwarg <{self.name}> will be removed. Please use <{self.new_name}>",
                     FutureWarning,
                 )
 

tests/test_exporters.py

@@ -4,6 +4,8 @@
 # core modules
 import sys
 import io
+from pathlib import Path
+import re
 
 # my modules
 from cadquery import *
@@ -214,3 +216,29 @@ def testTypeHandling(self):
 
         with self.assertRaises(ValueError):
             exporters.export(self._box(), "out.stl", "STP")
+
+
+def test_assy_vtk_rotation(tmp_path_factory):
+    tmpdir = tmp_path_factory.mktemp("out")
+
+    v0 = Vertex.makeVertex(1, 0, 0)
+
+    assy = Assembly()
+    assy.add(
+        v0, name="v0", loc=Location(Vector(0, 0, 0), Vector(1, 0, 0), 90),
+    )
+
+    fwrl = Path(tmpdir, "v0.wrl")
+    assert not fwrl.exists()
+    assy.save(str(fwrl), "VRML")
+    assert fwrl.exists()
+
+    matched_rot = False
+    with open(fwrl) as f:
+        pat_rot = re.compile("""rotation 1 0 0 1.5707963267""")
+        for line in f:
+            if m := re.search(pat_rot, line):
+                matched_rot = True
+                break
+
+    assert matched_rot