Skip to content

Closes #786 Asymmetric Chamfer Error #1579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Closes #786 Asymmetric Chamfer Error #1579

wants to merge 4 commits into from

Conversation

kolod
Copy link

@kolod kolod commented May 1, 2024 •
edited
Loading

Closes #786 Asymmetric Chamfer Error

cadquery uses random edge face when call into chamfer_builder.Add()

Fix uses face on which edge selected in chamfer_builder.Add() call

Example:

Workplane().box(10, 10, 10).faces("<X").chamfer(1, 2)

image

If both faces of the edge are selected chamfer now uses length2 for length to prevent unexpected behavior.

Example:

Workplane().box(10, 10, 10).faces("<Y or <X").edges("|Z").chamfer(1, 2)

image

@kolod kolod changed the title fix #786 Asymmetric Chamfer Error Closes #786 Asymmetric Chamfer Error May 1, 2024
@adam-urbanczyk
Copy link
Member

Thanks for the PR, but looks like you still fail on mypy (annotations) and call show from the test which causes an error on azure. We'll probably need to discuss the proposed semantics too.

@adam-urbanczyk
Copy link
Member

@kolod do you intend to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asymmetric Chamfer Error
2 participants
@kolod @adam-urbanczyk