Skip to content

Commit 2624cc0

Browse files
authored
Fix error message when altering a non-exist user (apache#16126)
1 parent e8f152a commit 2624cc0

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBRelationalAuthIT.java

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
import java.util.HashSet;
4545
import java.util.Set;
4646

47+
import static org.junit.jupiter.api.Assertions.assertEquals;
48+
4749
@RunWith(IoTDBTestRunner.class)
4850
@Category({TableLocalStandaloneIT.class, TableClusterIT.class})
4951
public class IoTDBRelationalAuthIT {
@@ -620,4 +622,16 @@ public void testCreateUserAndRole() throws SQLException {
620622
Assert.fail();
621623
}
622624
}
625+
626+
@Test
627+
public void testAlterNonExistingUser() throws SQLException {
628+
try (Connection adminCon = EnvFactory.getEnv().getConnection(BaseEnv.TABLE_SQL_DIALECT);
629+
Statement adminStmt = adminCon.createStatement()) {
630+
try {
631+
adminStmt.execute("ALTER USER nonExist SET PASSWORD 'asdfer1124566'");
632+
} catch (SQLException e) {
633+
assertEquals("701: User nonExist not found", e.getMessage());
634+
}
635+
}
636+
}
623637
}

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/auth/ClusterAuthorityFetcher.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -540,10 +540,10 @@ public User getUser(String userName) {
540540
} catch (ClientManagerException | TException e) {
541541
LOGGER.error(CONNECTERROR);
542542
}
543-
user = cacheUser(permissionInfoResp);
544543
if (permissionInfoResp != null
545544
&& permissionInfoResp.getStatus().getCode()
546545
== TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
546+
user = cacheUser(permissionInfoResp);
547547
if (acceptCache) {
548548
iAuthorCache.putUserCache(userName, user);
549549
}

0 commit comments

Comments
 (0)