Skip to content

Commit 2a12077

Browse files
authored
Don't print warn msg while meeting 400 (apache#16597)
1 parent 1d852bf commit 2a12077

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/mqtt/MPPPublishHandler.java

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -130,16 +130,18 @@ public void onPublish(InterceptPublishMessage msg) {
130130
MqttClientSession session = clientIdToSessionMap.get(msg.getClientID());
131131
ByteBuf payload = msg.getPayload();
132132
String topic = msg.getTopicName();
133-
String username = msg.getUsername();
134-
MqttQoS qos = msg.getQos();
135133

136-
LOG.debug(
137-
"Receive publish message. clientId: {}, username: {}, qos: {}, topic: {}, payload: {}",
138-
clientId,
139-
username,
140-
qos,
141-
topic,
142-
payload);
134+
if (LOG.isDebugEnabled()) {
135+
String username = msg.getUsername();
136+
MqttQoS qos = msg.getQos();
137+
LOG.debug(
138+
"Receive publish message. clientId: {}, username: {}, qos: {}, topic: {}, payload: {}",
139+
clientId,
140+
username,
141+
qos,
142+
topic,
143+
payload);
144+
}
143145

144146
List<Message> messages = payloadFormat.format(topic, payload);
145147
if (messages == null) {
@@ -188,8 +190,11 @@ private void insertTable(TableMessage message, MqttClientSession session) {
188190
config.getQueryTimeoutThreshold());
189191

190192
tsStatus = result.status;
191-
LOG.debug("process result: {}", tsStatus);
192-
if (tsStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
193+
if (LOG.isDebugEnabled()) {
194+
LOG.debug("process result: {}", tsStatus);
195+
}
196+
if (tsStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
197+
|| tsStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
193198
LOG.warn("mqtt line insert error , message = {}", tsStatus.message);
194199
}
195200
} catch (Exception e) {
@@ -301,8 +306,11 @@ private void insertTree(TreeMessage message, MqttClientSession session) {
301306
config.getQueryTimeoutThreshold(),
302307
false);
303308
tsStatus = result.status;
304-
LOG.debug("process result: {}", tsStatus);
305-
if (tsStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
309+
if (LOG.isDebugEnabled()) {
310+
LOG.debug("process result: {}", tsStatus);
311+
}
312+
if (tsStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
313+
|| tsStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
306314
LOG.warn("mqtt json insert error , message = {}", tsStatus.message);
307315
}
308316
}

0 commit comments

Comments
 (0)