Optimized the config execution & query failure logs

Author: Caideyipi

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/template/CreateSchemaTemplatePlan.java

@@ -38,7 +38,7 @@ public CreateSchemaTemplatePlan() {
     super(ConfigPhysicalPlanType.CreateSchemaTemplate);
   }
 
-  public CreateSchemaTemplatePlan(byte[] templateData) {
+  public CreateSchemaTemplatePlan(final byte[] templateData) {
     this();
     this.templateData = templateData;
   }
@@ -48,33 +48,33 @@ public byte[] getTemplateData() {
   }
 
   public Template getTemplate() {
-    Template template = new Template();
+    final Template template = new Template();
     template.deserialize(ByteBuffer.wrap(templateData));
     return template;
   }
 
   @Override
-  protected void serializeImpl(DataOutputStream stream) throws IOException {
+  protected void serializeImpl(final DataOutputStream stream) throws IOException {
     stream.writeShort(getType().getPlanType());
     stream.writeInt(templateData.length);
     stream.write(templateData);
   }
 
   @Override
-  protected void deserializeImpl(ByteBuffer buffer) throws IOException {
-    int length = ReadWriteIOUtils.readInt(buffer);
+  protected void deserializeImpl(final ByteBuffer buffer) throws IOException {
+    final int length = ReadWriteIOUtils.readInt(buffer);
     this.templateData = ReadWriteIOUtils.readBytes(buffer, length);
   }
 
   @Override
-  public boolean equals(Object o) {
+  public boolean equals(final Object o) {
     if (this == o) {
       return true;
     }
     if (o == null || getClass() != o.getClass()) {
       return false;
     }
-    CreateSchemaTemplatePlan that = (CreateSchemaTemplatePlan) o;
+    final CreateSchemaTemplatePlan that = (CreateSchemaTemplatePlan) o;
     return Arrays.equals(that.templateData, templateData);
   }
 

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java

@@ -734,9 +734,9 @@ public Pair<Set<TSchemaNode>, Set<PartialPath>> getChildNodePathInNextLevel(
     return matchedPathsInNextLevel;
   }
 
-  public TSStatus createSchemaTemplate(CreateSchemaTemplatePlan createSchemaTemplatePlan) {
+  public TSStatus createSchemaTemplate(final CreateSchemaTemplatePlan createSchemaTemplatePlan) {
     try {
-      Template template = createSchemaTemplatePlan.getTemplate();
+      final Template template = createSchemaTemplatePlan.getTemplate();
       templateTable.createTemplate(template);
       return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
     } catch (MetadataException e) {

iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java

@@ -107,10 +107,10 @@ public List<Template> getAllTemplate() {
     }
   }
 
-  public void createTemplate(Template template) throws MetadataException {
+  public void createTemplate(final Template template) throws MetadataException {
     templateReadWriteLock.writeLock().lock();
     try {
-      Template temp = this.templateMap.get(template.getName());
+      final Template temp = this.templateMap.get(template.getName());
       if (temp != null) {
         LOGGER.error(
             "Failed to create template, because template name {} exists", template.getName());

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java

@@ -47,7 +47,12 @@
 
 import java.io.IOException;
 import java.nio.ByteBuffer;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Objects;
 import java.util.Optional;
+import java.util.Set;
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.ExecutorService;
 
@@ -56,6 +61,38 @@ public class ConfigExecution implements IQueryExecution {
   private static final Logger LOGGER = LoggerFactory.getLogger(ConfigExecution.class);
 
   private static final TsBlockSerde serde = new TsBlockSerde();
+  private static final Set<Integer> userExceptionCodes =
+      Collections.unmodifiableSet(
+          new HashSet<>(
+              Arrays.asList(
+                  TSStatusCode.DATABASE_NOT_EXIST.getStatusCode(),
+                  TSStatusCode.DATABASE_ALREADY_EXISTS.getStatusCode(),
+                  TSStatusCode.DATABASE_CONFLICT.getStatusCode(),
+                  TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode(),
+                  TSStatusCode.PATH_NOT_EXIST.getStatusCode(),
+                  TSStatusCode.MEASUREMENT_ALREADY_EXISTS_IN_TEMPLATE.getStatusCode(),
+                  TSStatusCode.SCHEMA_QUOTA_EXCEEDED.getStatusCode(),
+                  TSStatusCode.TABLE_ALREADY_EXISTS.getStatusCode(),
+                  TSStatusCode.TABLE_NOT_EXISTS.getStatusCode(),
+                  TSStatusCode.COLUMN_ALREADY_EXISTS.getStatusCode(),
+                  TSStatusCode.COLUMN_NOT_EXISTS.getStatusCode(),
+                  TSStatusCode.COLUMN_CATEGORY_MISMATCH.getStatusCode(),
+                  TSStatusCode.DATABASE_MODEL.getStatusCode(),
+                  TSStatusCode.DATABASE_CONFLICT.getStatusCode(),
+                  TSStatusCode.TEMPLATE_IS_IN_USE.getStatusCode(),
+                  TSStatusCode.TEMPLATE_NOT_SET.getStatusCode(),
+                  TSStatusCode.TEMPLATE_INCOMPATIBLE.getStatusCode(),
+                  TSStatusCode.UNDEFINED_TEMPLATE.getStatusCode(),
+                  TSStatusCode.TEMPLATE_NOT_ACTIVATED.getStatusCode(),
+                  TSStatusCode.USER_ALREADY_EXIST.getStatusCode(),
+                  TSStatusCode.USER_NOT_EXIST.getStatusCode(),
+                  TSStatusCode.NO_PERMISSION.getStatusCode(),
+                  TSStatusCode.NOT_HAS_PRIVILEGE.getStatusCode(),
+                  TSStatusCode.ROLE_ALREADY_EXIST.getStatusCode(),
+                  TSStatusCode.ROLE_NOT_EXIST.getStatusCode(),
+                  TSStatusCode.USER_ALREADY_HAS_ROLE.getStatusCode(),
+                  TSStatusCode.USER_NOT_HAS_ROLE.getStatusCode(),
+                  TSStatusCode.NOT_HAS_PRIVILEGE_GRANTOPT.getStatusCode())));
 
   private final MPPQueryContext context;
   private final ExecutorService executor;
@@ -118,8 +155,20 @@ public void onFailure(@NotNull Throwable throwable) {
     }
   }
 
-  private void fail(Throwable cause) {
-    LOGGER.warn("Failures happened during running ConfigExecution.", cause);
+  private void fail(final Throwable cause) {
+    if (!(cause instanceof IoTDBException)
+        || !userExceptionCodes.contains(((IoTDBException) cause).getErrorCode())) {
+      LOGGER.warn(
+          "Failures happened during running ConfigExecution when executing {}.",
+          Objects.nonNull(task) ? task.getClass().getSimpleName() : null,
+          cause);
+    } else {
+      LOGGER.info(
+          "Failures happened during running ConfigExecution when executing {}, message: {}, status: {}",
+          Objects.nonNull(task) ? task.getClass().getSimpleName() : null,
+          cause.getMessage(),
+          ((IoTDBException) cause).getErrorCode());
+    }
     stateMachine.transitionToFailed(cause);
     ConfigTaskResult result;
     if (cause instanceof IoTDBException) {