Fix the error message when the number of columns in a Insert SQL is inconsistent (apache#16083)

Author: jt2594838

integration-test/src/test/java/org/apache/iotdb/relational/it/session/IoTDBSessionRelationalIT.java

@@ -1282,6 +1282,40 @@ public void insertWithoutFieldTest() throws IoTDBConnectionException {
     }
   }
 
+  @Test
+  public void insertWrongFieldNumTest() throws IoTDBConnectionException {
+    try (ITableSession session = EnvFactory.getEnv().getTableSessionConnection()) {
+      session.executeNonQueryStatement("USE \"db1\"");
+      session.executeNonQueryStatement(
+          "create table wrong_field_num (s1 int32, s2 int32, s3 int32)");
+      session.executeNonQueryStatement(
+          "insert into wrong_field_num(s1, s2, s3, time) values (1, 2, 3)");
+      fail("Exception expected");
+    } catch (StatementExecutionException e) {
+      assertEquals("701: TimeColumnIndex out of bound: 3-3", e.getMessage());
+    }
+
+    try (ITableSession session = EnvFactory.getEnv().getTableSessionConnection()) {
+      session.executeNonQueryStatement("USE \"db1\"");
+      session.executeNonQueryStatement(
+          "insert into wrong_field_num(s1, s2, time, s3) values (1, 2, 3)");
+      fail("Exception expected");
+    } catch (StatementExecutionException e) {
+      assertEquals(
+          "701: Inconsistent numbers of non-time column names and values: 3-2", e.getMessage());
+    }
+
+    try (ITableSession session = EnvFactory.getEnv().getTableSessionConnection()) {
+      session.executeNonQueryStatement("USE \"db1\"");
+      session.executeNonQueryStatement(
+          "insert into wrong_field_num(s1, s2, time) values (1, 2, 3, 4)");
+      fail("Exception expected");
+    } catch (StatementExecutionException e) {
+      assertEquals(
+          "701: Inconsistent numbers of non-time column names and values: 2-3", e.getMessage());
+    }
+  }
+
   private void testOneCastWithTablet(
       TSDataType from, TSDataType to, int testNum, boolean partialInsert)
       throws IoTDBConnectionException, StatementExecutionException {

iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java

@@ -852,7 +852,12 @@ private Node visitInsertValues(
                   }
                   String[] columnNameArray = columnNames.toArray(new String[0]);
                   return toInsertRowStatement(
-                      expressions, finalTimeColumnIndex, columnNameArray, tableName, databaseName);
+                      expressions,
+                      finalTimeColumnIndex,
+                      columnNameArray,
+                      tableName,
+                      databaseName,
+                      columnNames.size());
                 })
             .collect(toList());
 
@@ -926,7 +931,8 @@ private InsertRowStatement toInsertRowStatement(
       int timeColumnIndex,
       String[] nonTimeColumnNames,
       String tableName,
-      String databaseName) {
+      String databaseName,
+      int columnSize) {
     InsertRowStatement insertRowStatement = new InsertRowStatement();
     insertRowStatement.setWriteToTable(true);
     insertRowStatement.setDevicePath(new PartialPath(new String[] {tableName}));
@@ -936,6 +942,12 @@ private InsertRowStatement toInsertRowStatement(
       timestamp = CommonDateTimeUtils.currentTime();
       nonTimeColCnt = expressions.size();
     } else {
+      if (timeColumnIndex >= expressions.size()) {
+        throw new SemanticException(
+            String.format(
+                "TimeColumnIndex out of bound: %d-%d", timeColumnIndex, expressions.size()));
+      }
+
       Expression timeExpression = expressions.get(timeColumnIndex);
       if (timeExpression instanceof LongLiteral) {
         timestamp = ((LongLiteral) timeExpression).getParsedValue();