Fix up Reflection.

Author: dereuromark

src/Method/AssociationTableMixinClassReflectionExtension.php

@@ -48,12 +48,12 @@ protected function getTableReflection(): ClassReflection
      */
     public function hasMethod(ClassReflection $classReflection, string $methodName): bool
     {
-        // Check if it's a native method first, before treating as magic
+        // Handle Table classes (including specific table classes accessed through associations)
         if ($classReflection->is(Table::class)) {
             if ($classReflection->hasNativeMethod($methodName)) {
                 return false; // Let the native method be used
             }
-            // magic findBy* method
+            // magic findBy* method - available on ALL table classes
             if (preg_match('/^find\w*By/', $methodName) > 0) {
                 return true;
             }
@@ -63,12 +63,11 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
             return false;
         }
 
-        // magic findBy* method on Association
-        // NOTE: We cannot check for native methods on the associated table class here
-        // because MethodsClassReflectionExtension doesn't have access to generic type parameters.
-        // This means custom methods matching find*By pattern will be treated as magic methods
-        // when accessed through associations. Use @method annotations to override.
+        // For associations with find*By methods, check if there's a concrete table class
+        // that can be determined from the property annotation
         if (preg_match('/^find\w*By/', $methodName) > 0) {
+            // TODO: Try to extract the table class from generic type parameter here
+            // For now, we return true to indicate we have the magic method
             return true;
         }
 
@@ -82,23 +81,28 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
      */
     public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection
     {
-        // Check if it's a native method first, before treating as magic
+        // Handle Table classes (including specific table classes accessed through associations)
         if ($classReflection->is(Table::class)) {
             if ($classReflection->hasNativeMethod($methodName)) {
                 return $classReflection->getNativeMethod($methodName);
             }
-            // magic findBy* method
+            // magic findBy* method - use the SPECIFIC table class for reflection
+            // This ensures that when accessed through Association<SpecificTable>,
+            // the magic method is created with the correct table class context
             if (preg_match('/^find\w*By/', $methodName) > 0) {
                 return new TableFindByPropertyMethodReflection($methodName, $classReflection);
             }
         }
 
-        // magic findBy* method on Association
+        // For associations, handle magic find*By methods
         $associationReflection = $this->reflectionProvider->getClass(Association::class);
         if (
             $classReflection->isSubclassOfClass($associationReflection)
             && preg_match('/^find\w*By/', $methodName) > 0
         ) {
+            // Return magic method based on base Table class
+            // LIMITATION: This doesn't know about the specific table class from generic parameter
+            // So custom findOrCreateBy methods on specific tables won't be detected through associations
             return new TableFindByPropertyMethodReflection($methodName, $this->getTableReflection());
         }