Fixed all the warnings I could

Geobot19 · CalcProgrammer1 · commit 1cfd60261e0b · 2023-07-06T23:39:19.000Z
diff --git a/Controllers/LianLiController/LianLiUniHub_AL10Controller.cpp b/Controllers/LianLiController/LianLiUniHub_AL10Controller.cpp
@@ -580,17 +580,17 @@ void LianLiUniHub_AL10Controller::Synchronize()
     \*--------------------------------------------------------------------*/
 //    uint8_t control = 0;
 
-//    /*-------------------------------------*\
-//    | Configure fan settings                |
-//    \*-------------------------------------*/
+    /*-------------------------------------*\
+    | Configure fan settings                |
+    \*-------------------------------------*/
 //    for(const Channel& channel : channels)
 //    {
 //        if(channel.fanSpeed == UNIHUB_AL10_FAN_SPEED_PWM)
 //        {
-//            /*-----------------------------*\
-//            | Configure the fan to pwm      |
-//            | control                       |
-//            \*-----------------------------*/
+            /*-----------------------------*\
+            | Configure the fan to pwm      |
+            | control                       |
+            \*-----------------------------*/
 //            uint8_t config_pwm[1] = { 0x00 };
 
 //            control |= (0x01 << channel.index);
@@ -600,20 +600,20 @@ void LianLiUniHub_AL10Controller::Synchronize()
 //        }
 //        else
 //        {
-//            /*-----------------------------*\
-//            | Configure the fan to hub      |
-//            | control and set speed         |
-//            \*-----------------------------*/
+            /*-----------------------------*\
+            | Configure the fan to hub      |
+            | control and set speed         |
+            \*-----------------------------*/
 //            uint8_t config_hub[2] = { (uint8_t)(channel.fanSpeed >> 0x08), (uint8_t)(channel.fanSpeed &  0xFF) };
 
 //            SendConfig(channel.fanHubActionAddress, config_hub, sizeof(config_hub));
 //            SendCommit(channel.fanHubCommitAddress);
 //        }
 //    }
 
-//    /*-------------------------------------*\
-//    | Configure fan control modes           |
-//    \*-------------------------------------*/
+    /*-------------------------------------*\
+    | Configure fan control modes           |
+    \*-------------------------------------*/
 //    uint8_t config_fan_mode[2] = { 0x31, (uint8_t)(0xF0 | control) };
 
 //    SendConfig(UNIHUB_AL10_ACTION_ADDRESS, config_fan_mode, sizeof(config_fan_mode));
diff --git a/Controllers/NollieController/NollieController.cpp b/Controllers/NollieController/NollieController.cpp
@@ -11,7 +11,7 @@
 
 using namespace std::chrono_literals;
 
-NollieController::NollieController(hid_device* dev_handle, const char* path, unsigned short pid)
+NollieController::NollieController(hid_device* dev_handle, const char* path, unsigned short /*pid*/)
 {
     dev         = dev_handle;
     location    = path;
diff --git a/Controllers/NollieController/RGBController_Nollie.cpp b/Controllers/NollieController/RGBController_Nollie.cpp
@@ -152,7 +152,7 @@ void RGBController_Nollie::DeviceUpdateLEDs()
         }
     }
     std::sort(ChSort.begin(), ChSort.end());
-    for (int i = 0; i < ChSort.size(); i++)
+    for (std::size_t i = 0; i < ChSort.size(); i++)
     {
         int* ptr = std::find(channel_index, channel_index + 32, ChSort[i]);
         int zone_idx = ptr - channel_index;
diff --git a/Controllers/OKSController/OKSKeyboardController.cpp b/Controllers/OKSController/OKSKeyboardController.cpp
@@ -50,7 +50,7 @@ unsigned short OKSKeyboardController::GetUSBPID()
     return(usb_pid);
 }
 
-void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int color_data_size)
+void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int /*color_data_size*/)
 {
     char usb_buf[65];
     union kb2_port_t Pack;
@@ -86,7 +86,7 @@ void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int c
     std::this_thread::sleep_for(std::chrono::milliseconds(5));
 }
 
-void OKSKeyboardController::SendKeyboardModeEx(const mode &m, unsigned char red, unsigned char green, unsigned char blue)
+void OKSKeyboardController::SendKeyboardModeEx(const mode &m, unsigned char /*red*/, unsigned char /*green*/, unsigned char /*blue*/)
 {
     union kb2_port_t Pack;
     kb2M_wrgb(&Pack, m.brightness, m.value, m.speed, m.direction);
diff --git a/Controllers/OKSController/RGBController_OKSKeyboard.cpp b/Controllers/OKSController/RGBController_OKSKeyboard.cpp
@@ -269,7 +269,7 @@ void RGBController_OKSKeyboard::DeviceUpdateLEDs()
     controller->SendColors(colordata, colors.size()*3);
 }
 
-void RGBController_OKSKeyboard::UpdateZoneLEDs(int zone)
+void RGBController_OKSKeyboard::UpdateZoneLEDs(int /*zone*/)
 {
     DeviceUpdateLEDs();
 }
@@ -290,7 +290,7 @@ void RGBController_OKSKeyboard::DeviceUpdateMode()
     unsigned char red    = 0x00;
     unsigned char grn    = 0x00;
     unsigned char blu    = 0x00;
-    unsigned char random = (modes[active_mode].color_mode == MODE_COLORS_RANDOM);
+    //unsigned char random = (modes[active_mode].color_mode == MODE_COLORS_RANDOM);
 
     if(modes[active_mode].colors.size() > 0)
     {
diff --git a/Controllers/PalitGPUController/PalitGPUControllerDetect.cpp b/Controllers/PalitGPUController/PalitGPUControllerDetect.cpp
@@ -28,7 +28,7 @@ void DetectPalitGPUControllers(i2c_smbus_interface* bus, uint8_t i2c_addr, const
     }
 
     const uint8_t palit[] = {'P', 'A', 'L', 'I', 'T'};
-    for (int i = 0; i < sizeof(palit); i++)
+    for (size_t i = 0; i < sizeof(palit); i++)
     {
         int32_t letter = bus->i2c_smbus_read_byte_data(i2c_addr, 0x07 + i);
         if (palit[i] != letter)
diff --git a/Controllers/SRGBmodsController/SRGBmodsLEDControllerV1.cpp b/Controllers/SRGBmodsController/SRGBmodsLEDControllerV1.cpp
@@ -43,7 +43,7 @@ std::string SRGBmodsLEDControllerV1::GetSerialString()
     return(return_string);
 }
 
-void SRGBmodsLEDControllerV1::SetChannelLEDs(unsigned char channel, RGBColor* colors, unsigned int num_colors)
+void SRGBmodsLEDControllerV1::SetChannelLEDs(unsigned char /*channel*/, RGBColor* colors, unsigned int num_colors)
 {
     /*-----------------------------------------------------*\
     | Determine number of packets to send                   |
diff --git a/Controllers/ZotacV2GPUController/RGBController_ZotacV2GPU.cpp b/Controllers/ZotacV2GPUController/RGBController_ZotacV2GPU.cpp
@@ -408,7 +408,7 @@ void RGBController_ZotacV2GPU::DeviceUpdateMode()
     if(zoneConfig.mode == ZOTAC_V2_GPU_MODE_DUET)
     {
         zoneConfig.colorPreset = ZOTAC_V2_GPU_DUET_PRESETS.size();  // custom
-        for(int i = 0; i < ZOTAC_V2_GPU_DUET_PRESETS.size(); ++i)
+        for(size_t i = 0; i < ZOTAC_V2_GPU_DUET_PRESETS.size(); ++i)
         {
             if(zoneConfig.color1 == ZOTAC_V2_GPU_DUET_PRESETS[i].first &&
                 zoneConfig.color2 == ZOTAC_V2_GPU_DUET_PRESETS[i].second)

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`using namespace std::chrono_literals;`
`13`	`13`
`14`		`-NollieController::NollieController(hid_device* dev_handle, const char* path, unsigned short pid)`
	`14`	`+NollieController::NollieController(hid_device* dev_handle, const char* path, unsigned short /pid/)`
`15`	`15`	`{`
`16`	`16`	`dev = dev_handle;`
`17`	`17`	`location = path;`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ void RGBController_Nollie::DeviceUpdateLEDs()`
`152`	`152`	`}`
`153`	`153`	`}`
`154`	`154`	`std::sort(ChSort.begin(), ChSort.end());`
`155`		`- for (int i = 0; i < ChSort.size(); i++)`
	`155`	`+ for (std::size_t i = 0; i < ChSort.size(); i++)`
`156`	`156`	`{`
`157`	`157`	`int* ptr = std::find(channel_index, channel_index + 32, ChSort[i]);`
`158`	`158`	`int zone_idx = ptr - channel_index;`
Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ unsigned short OKSKeyboardController::GetUSBPID()`
`50`	`50`	`return(usb_pid);`
`51`	`51`	`}`
`52`	`52`
`53`		`-void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int color_data_size)`
	`53`	`+void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int /color_data_size/)`
`54`	`54`	`{`
`55`	`55`	`char usb_buf[65];`
`56`	`56`	`union kb2_port_t Pack;`
`@@ -86,7 +86,7 @@ void OKSKeyboardController::SendColors(unsigned char* color_data, unsigned int c`
`86`	`86`	`std::this_thread::sleep_for(std::chrono::milliseconds(5));`
`87`	`87`	`}`
`88`	`88`
`89`		`-void OKSKeyboardController::SendKeyboardModeEx(const mode &m, unsigned char red, unsigned char green, unsigned char blue)`
	`89`	`+void OKSKeyboardController::SendKeyboardModeEx(const mode &m, unsigned char /red/, unsigned char /green/, unsigned char /blue/)`
`90`	`90`	`{`
`91`	`91`	`union kb2_port_t Pack;`
`92`	`92`	`kb2M_wrgb(&Pack, m.brightness, m.value, m.speed, m.direction);`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ void RGBController_OKSKeyboard::DeviceUpdateLEDs()`
`269`	`269`	`controller->SendColors(colordata, colors.size()*3);`
`270`	`270`	`}`
`271`	`271`
`272`		`-void RGBController_OKSKeyboard::UpdateZoneLEDs(int zone)`
	`272`	`+void RGBController_OKSKeyboard::UpdateZoneLEDs(int /zone/)`
`273`	`273`	`{`
`274`	`274`	`DeviceUpdateLEDs();`
`275`	`275`	`}`
`@@ -290,7 +290,7 @@ void RGBController_OKSKeyboard::DeviceUpdateMode()`
`290`	`290`	`unsigned char red = 0x00;`
`291`	`291`	`unsigned char grn = 0x00;`
`292`	`292`	`unsigned char blu = 0x00;`
`293`		`- unsigned char random = (modes[active_mode].color_mode == MODE_COLORS_RANDOM);`
	`293`	`+ //unsigned char random = (modes[active_mode].color_mode == MODE_COLORS_RANDOM);`
`294`	`294`
`295`	`295`	`if(modes[active_mode].colors.size() > 0)`
`296`	`296`	`{`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ void DetectPalitGPUControllers(i2c_smbus_interface* bus, uint8_t i2c_addr, const`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`const uint8_t palit[] = {'P', 'A', 'L', 'I', 'T'};`
`31`		`- for (int i = 0; i < sizeof(palit); i++)`
	`31`	`+ for (size_t i = 0; i < sizeof(palit); i++)`
`32`	`32`	`{`
`33`	`33`	`int32_t letter = bus->i2c_smbus_read_byte_data(i2c_addr, 0x07 + i);`
`34`	`34`	`if (palit[i] != letter)`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ std::string SRGBmodsLEDControllerV1::GetSerialString()`
`43`	`43`	`return(return_string);`
`44`	`44`	`}`
`45`	`45`
`46`		`-void SRGBmodsLEDControllerV1::SetChannelLEDs(unsigned char channel, RGBColor* colors, unsigned int num_colors)`
	`46`	`+void SRGBmodsLEDControllerV1::SetChannelLEDs(unsigned char /channel/, RGBColor* colors, unsigned int num_colors)`
`47`	`47`	`{`
`48`	`48`	`/-----------------------------------------------------\`
`49`	`49`	`\| Determine number of packets to send \|`
Original file line number	Diff line number	Diff line change
`@@ -408,7 +408,7 @@ void RGBController_ZotacV2GPU::DeviceUpdateMode()`
`408`	`408`	`if(zoneConfig.mode == ZOTAC_V2_GPU_MODE_DUET)`
`409`	`409`	`{`
`410`	`410`	`zoneConfig.colorPreset = ZOTAC_V2_GPU_DUET_PRESETS.size(); // custom`
`411`		`- for(int i = 0; i < ZOTAC_V2_GPU_DUET_PRESETS.size(); ++i)`
	`411`	`+ for(size_t i = 0; i < ZOTAC_V2_GPU_DUET_PRESETS.size(); ++i)`
`412`	`412`	`{`
`413`	`413`	`if(zoneConfig.color1 == ZOTAC_V2_GPU_DUET_PRESETS[i].first &&`
`414`	`414`	`zoneConfig.color2 == ZOTAC_V2_GPU_DUET_PRESETS[i].second)`