You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I’ve recently started using the Fluids package for control valve sizing and I’m really impressed with the depth of the library. As a process engineer, I'd love to contribute some enhancements to make the control_valve module even more robust for real-world applications.
Robust Flow Input for Gas Sizing
Currently, the gas sizing functions primarily focus on standard volumetric flow. In industrial practice, we frequently work with mass flow or actual volumetric flow. I propose updating the sizing functions to natively accept:
• Mass flow rate
• Actual volumetric flow rate
I plan to implement this by adding optional arguments to the existing functions, ensuring zero breaking changes for current users while eliminating the need for external manual conversions.
Architectural Improvement: Transition to Module
To improve the long-term maintainability and scalability of the codebase, I suggest refactoring control_valve.py into a proper module (a directory with an init.py). This will allow us to:
• Clean up the internal architecture.
• Make the code more "Pythonic" and easier for others to contribute to.
• Keep the public API identical so existing imports continue to work seamlessly.
I’m excited to use Fluids for my own engineering products and would love to give back to the community. Please let me know if these suggestions align with the project roadmap, and I’ll be happy to submit a PR!
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi,
I’ve recently started using the Fluids package for control valve sizing and I’m really impressed with the depth of the library. As a process engineer, I'd love to contribute some enhancements to make the control_valve module even more robust for real-world applications.
Currently, the gas sizing functions primarily focus on standard volumetric flow. In industrial practice, we frequently work with mass flow or actual volumetric flow. I propose updating the sizing functions to natively accept:
• Mass flow rate
• Actual volumetric flow rate
I plan to implement this by adding optional arguments to the existing functions, ensuring zero breaking changes for current users while eliminating the need for external manual conversions.
To improve the long-term maintainability and scalability of the codebase, I suggest refactoring control_valve.py into a proper module (a directory with an init.py). This will allow us to:
• Clean up the internal architecture.
• Make the code more "Pythonic" and easier for others to contribute to.
• Keep the public API identical so existing imports continue to work seamlessly.
I’m excited to use Fluids for my own engineering products and would love to give back to the community. Please let me know if these suggestions align with the project roadmap, and I’ll be happy to submit a PR!
Beta Was this translation helpful? Give feedback.
All reactions